Closed Bug 792391 Opened 7 years ago Closed 7 years ago

Add a TARGET_LOCAL_INCLUDES variable to be used for compiling target sources only, not host sources

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file)

The new Breakpad update includes some compatibility headers for Android, so we need to add -I <that dir> for our target sources. Unfortunately we also build host sources in some directories, so adding it to LOCAL_INCLUDES breaks the host compilation. This patch adds a TARGET_LOCAL_INCLUDES variable that only gets used for target compilation, not host compilation.

I toyed with making LOCAL_INCLUDES not work for host compilation and adding a HOST_LOCAL_INCLUDES instead, but I was worried about build fallout.
Blocks: 791775
Attachment #662520 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/f0768a9d3a04
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Depends on: 1252804
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.