Closed
Bug 792483
Opened 12 years ago
Closed 11 years ago
conditionally define Win32Process *iff* the imports succeed
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Unassigned)
Details
We happily ignore the fact that if we don't have pywin32 installed the imports fail: http://hg.mozilla.org/build/talos/file/38609147b9db/talos/ffprocess_win32.py#l17 For one, this should be `except ImportError`, not a bare 'except'. But the more important bug is that we define Win32Process even when the import fails. Instead, we should only flush out the Win32Process class *iff* these imports succeed, since we use them and they will fail if they're not defined. If we need Win32Process to be defined if these fail, it should be defined to None.
Comment 1•11 years ago
|
||
talos pywin32 support has been removed in bug 726700
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•