Closed Bug 792580 Opened 7 years ago Closed 7 years ago

[elm] --disable-crashreporter causes build error during "make installer"

Categories

(Firefox Build System :: General, defect)

x86_64
Windows 8
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: TimAbraldes, Assigned: TimAbraldes)

References

Details

(Whiteboard: completed-elm)

Attachments

(1 file)

package-manifest.in does not try to package any crashreporter files if `MOZ_CRASHREPORTER` is not defined [1][2].

On elm, we have a package.manifest file alongside package-manifest.in.  In it, crashreporter-override.ini is listed even if `MOZ_CRASHREPORTER` is not defined [3].  Attempting to make the installer currently fails on elm with an error saying that crashreporter-override.ini could not be found.

The line containing "crashreporter-override.ini" should be moved inside an `#ifdef MOZ_CRASHREPORTER`.

[1] https://hg.mozilla.org/mozilla-central/file/0c8ac138706e/browser/installer/package-manifest.in#l664
[2] https://hg.mozilla.org/projects/elm/file/455428eb5fe0/browser/installer/package-manifest.in#l662
[2] https://hg.mozilla.org/projects/elm/file/455428eb5fe0/browser/installer/package.manifest#l285
Blocks: metro-build
This looks like it might belong down in dist/bin.
Attached patch PatchSplinter Review
This patch adds a "#ifdef MOZ_CRASHREPORTER" around the crashreporter-override.ini line in "package.manifest".

I'll test as soon as I can clobber build.
Attachment #662704 - Flags: review?(jmathies)
Attachment #662704 - Flags: review?(jmathies) → review+
Attachment #662704 - Flags: review+
(In reply to Tim Abraldes (:timA) (:tabraldes) from comment #2)
> Created attachment 662704 [details] [diff] [review]
> Patch
> 
> This patch adds a "#ifdef MOZ_CRASHREPORTER" around the
> crashreporter-override.ini line in "package.manifest".
> 
> I'll test as soon as I can clobber build.

Tested: I'm able to successfully build the installer with --disable-crashreporter and this patch applied.

https://hg.mozilla.org/projects/elm/rev/3ba4a4cf5775
Whiteboard: completed-elm
No longer blocks: metro-build
Blocks: new-packager
fixed w/the packager code
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.