792604 - Permission Settings followup fixes

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gregor Wagner [:gwagner]]

There current permission logic doesn't work.

Comment 1

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 662726 [details] [diff] [review]
patch

Review of attachment 662726 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/interfaces/permission/nsIDOMPermissionSettings.idl
@@ +13,2 @@
>  
> +  void set(in DOMString permission, in DOMString manifestURI, in DOMString origin, in DOMString value, in bool browserFlag);

Please keep the manifestURL+origin+browserflag arguments together. So move the value argument to be the second argument. Sorry for not catching that the first time around.

Comment 3

[David Dahl :ddahl]

Should this (in Webapps.jsm):

aData.mm.broadcastMessage("Webapps:Uninstall:Return:KO", aData);

be:

this.broadcastMessage("Webapps:Uninstall:Return:KO", aData);

?

aData inside uninstall is a JSON object, right?

Comment 4

[David Dahl :ddahl]

(In reply to David Dahl :ddahl from comment #3)
> be:
> 
> this.broadcastMessage("Webapps:Uninstall:Return:KO", aData);

Maybe not. As the "this" reference is inside another function above

Comment 5

[[:fabrice] Fabrice Desré]

NO, it should be aData.mm.sendAsyncMessage(...)

Comment 6

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7c33cfd00ffc

David, please not the rearranged argument list!

Comment 7

[David Dahl :ddahl]

(In reply to Gregor Wagner [:gwagner] from comment #6)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/7c33cfd00ffc
> 
> David, please not the rearranged argument list!

What?

Comment 8

[Gregor Wagner [:gwagner]]

(In reply to David Dahl :ddahl from comment #7)
> (In reply to Gregor Wagner [:gwagner] from comment #6)
> > https://hg.mozilla.org/integration/mozilla-inbound/rev/7c33cfd00ffc
> > 
> > David, please not the rearranged argument list!
> 
> What?

Ah my auto-correct does strange things.
Please see comment 2. I rearranged the arguments of the API.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7c33cfd00ffc

Comment 11

[Etienne Segonzac (:etienne)]

Still failing on B2G...

see https://bugzilla.mozilla.org/show_bug.cgi?id=793198