GonkHal vibrator code incorrectly uses a weak reference

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dhylands, Assigned: dhylands)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
GonkHal tries to register a weak reference for the xpcom shutdown event, but it the VibratorRunnable doesn't implement weak references. If you try to add weak reference support to VibratorRunnable, then you can't use it NS_NewThread.

There is also some issues with shutdown where it may try to reinstantiate a new runnable if Vibrate or CancelVibrate is called after shutdown is initiated.
(Assignee)

Comment 1

5 years ago
Created attachment 662827 [details] [diff] [review]
Cleanup shutdown code - remove weak reference
Attachment #662827 - Flags: review?(kyle)
Attachment #662827 - Flags: review?(kyle) → review+
https://hg.mozilla.org/mozilla-central/rev/30a90cdc3618
Assignee: nobody → dhylands
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Assignee: dhylands → dhylands
You need to log in before you can comment on or make changes to this bug.