Closed
Bug 79271
Opened 24 years ago
Closed 24 years ago
Option-specific #defines should move from BuildFlags.pm into MozillaCheckoutList.txt
Categories
(SeaMonkey :: Build Config, defect, P4)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.2
People
(Reporter: sfraser_bugs, Assigned: peterv)
Details
Attachments
(3 files)
|
4.07 KB,
patch
|
Details | Diff | Splinter Review | |
|
3.88 KB,
patch
|
Details | Diff | Splinter Review | |
|
3.75 KB,
patch
|
Details | Diff | Splinter Review |
BuildFlags.pm is supposed to be build-agnostic, but the stuff in
SetOptionDefines() breaks this. We should move the option-specified #defines into
MozillaCheckoutList.txt.
|
Assignee | |
Comment 1•24 years ago
|
||
Attaching a patch. It's a bit hacky, but I'm looking for an r= anyway ;-).
Status: NEW → ASSIGNED
Priority: -- → P4
Target Milestone: --- → mozilla0.9.2
|
|
Assignee | |
Comment 2•24 years ago
|
||
|
|
Assignee | |
Comment 3•24 years ago
|
||
Attaching new version. Allows only one define per flag (though can easily be
changed to support more).
|
|
Assignee | |
Comment 4•24 years ago
|
||
|
|
Assignee | |
Comment 5•24 years ago
|
||
|
Reporter | |
Comment 6•24 years ago
|
||
looks good. r=sfraser
|
|
Assignee | |
Comment 7•24 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
|
||
Updated•21 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•