Closed Bug 792798 Opened 7 years ago Closed 6 years ago

B2G SMS: develop test cases for Message Class 2

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
1.3 C1/1.4 S1(20dec)

People

(Reporter: vicamo, Assigned: bevis)

References

Details

Attachments

(1 file)

The WRITE_SMS_TO_SIM handler function in Android emulator is nothing but a stub and ENVELOPE command is still not implemented in AOSP master. Develop test cases for Message Class 2 once becoming possible.

See bug 736706.
Component: DOM: Device Interfaces → RIL
Product: Core → Firefox OS
Depends on: 943749
QA Contact: btseng
QA Contact: btseng
Depends on: 949318
Assignee: nobody → btseng
Update the issue description below to follow up:
1. According to the investigation and the implementation in bug#943749, 
   we realized that the Class 2 SMS comes with different RIL command
   |UNSOLICITED_RESPONSE_NEW_SMS_ON_SIM| compared to 
   |UNSOLICITED_RESPONSE_NEW_SMS| for normal incoming SMS.
2. SMS-PP Download is handled by modem directly without exposing it to RIL.
3. Hence, the test case to be added here is to cover the call flow of receiving Class 2 SMS on SIM as followed:
   - To get the record number of the incoming SMS in (U)SIM reported by UNSOLICITED_RESPONSE_NEW_SMS_ON_SIM.
   - To read the SMS from the EF_SMS with the specified record number.
   - To Notify new SMS to upper layer.
Hi Vicamo,

I'd like to add the test case to cover the call flow of receiving Class 2 SMS on SIM as followed:
- To get the record number of the incoming SMS in (U)SIM reported by UNSOLICITED_RESPONSE_NEW_SMS_ON_SIM.
- To read the SMS from the EF_SMS with the specified record number.
- To Notify new SMS to upper layer.

Thanks for your time for reviewing it.
Attachment #8348615 - Flags: review?(vyang)
Comment on attachment 8348615 [details] [diff] [review]
Part_1_Test_Case_V1: develop test cases for Message Class 2. r=vyang.

Review of attachment 8348615 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :)
Attachment #8348615 - Flags: review?(vyang) → review+
1. Update try server test result:
https://tbpl.mozilla.org/?tree=Try&rev=af8c8e4a8d8a
2. Mark |checkin-needed|.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/06fed52e21b5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
Depends on: 973895
You need to log in before you can comment on or make changes to this bug.