792798 - B2G SMS: develop test cases for Message Class 2

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

The WRITE_SMS_TO_SIM handler function in Android emulator is nothing but a stub and ENVELOPE command is still not implemented in AOSP master. Develop test cases for Message Class 2 once becoming possible.

See bug 736706.

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Update the issue description below to follow up:
1. According to the investigation and the implementation in bug#943749, 
   we realized that the Class 2 SMS comes with different RIL command
   |UNSOLICITED_RESPONSE_NEW_SMS_ON_SIM| compared to 
   |UNSOLICITED_RESPONSE_NEW_SMS| for normal incoming SMS.
2. SMS-PP Download is handled by modem directly without exposing it to RIL.
3. Hence, the test case to be added here is to cover the call flow of receiving Class 2 SMS on SIM as followed:
   - To get the record number of the incoming SMS in (U)SIM reported by UNSOLICITED_RESPONSE_NEW_SMS_ON_SIM.
   - To read the SMS from the EF_SMS with the specified record number.
   - To Notify new SMS to upper layer.

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Part_1_Test_Case_V1: develop test cases for Message Class 2. r=vyang.

Hi Vicamo,

I'd like to add the test case to cover the call flow of receiving Class 2 SMS on SIM as followed:
- To get the record number of the incoming SMS in (U)SIM reported by UNSOLICITED_RESPONSE_NEW_SMS_ON_SIM.
- To read the SMS from the EF_SMS with the specified record number.
- To Notify new SMS to upper layer.

Thanks for your time for reviewing it.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8348615 [details] [diff] [review]
Part_1_Test_Case_V1: develop test cases for Message Class 2. r=vyang.

Review of attachment 8348615 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :)

Comment 4

[Bevis Tseng[:bevis][:btseng](Exited)]

1. Update try server test result:
https://tbpl.mozilla.org/?tree=Try&rev=af8c8e4a8d8a
2. Mark |checkin-needed|.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/06fed52e21b5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/06fed52e21b5