79280 - Mac build system should have a fast_update option

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P4)

Description

[Simon Fraser [no longer active]]

Having a fast_update option in the Mac build scripts, that queries Bonsai to get 
the list of files to update, would be cool.

Comment 1

[Simon Fraser [no longer active]]

Attachment: BuildCore.pm changes to implement fast_update

Comment 2

[Simon Fraser [no longer active]]

With these changes, and a new version of MacCVS Pro (which you can only get by 
building the MacCVS Pro tip right now), you can do fast_update by setting 

FAST_UPDATE 1

in your build prefs. This acts as follows:
* If you've never checked out before, or the stored checkout time file does
  not exist, it does a normal checkout
* If you last checked out more than a week ago, it does a normal checkout.

It stores the checkout timestamp in a file called 'Last update time' in the tree 
root dir. This file contains an Epoch seconds value (hence GMT). The script 
always checks out files checked in during the last (1 + (hours diff)) hours, to 
ensure that no files are missed.

Bad things about this page (some are shared with fast_update on other platforms)
1. It only checks out files checked into the tip (i.e.not NSPR etc)
2. It puts build-specific logic in a file that is supposed to be build-agnostic
3. 'Last update time' is a bad name for the file.
4. Having fast_udpate on for the commercial build probably doesn't work.

Hey, but it's a start!

Comment 3

[Simon Fraser [no longer active]]

Attachment: Better patch

Comment 4

[Simon Fraser [no longer active]]

Last patch removed debugging cruft, fixes filename, and stores the time at the 
_start_ of checkout/update.

Comment 5

[rubydoo123]

9.2

Comment 6

[Simon Fraser [no longer active]]

-> mozilla 1.0

Comment 7

[Simon Fraser [no longer active]]

Attachment: Better patch; fast-updates each module in the checkout list

Comment 8

[Simon Fraser [no longer active]]

That last patch does a fast-update on each module in the MozillaCheckoutList.txt 
file, ignoring modules that are pulled by date, and using the branch tag as 
appropriate. I declare it finished.

Note that for it to work, you have to have a recent MacCVS Pro build (2.7d7 or 
later).

Comment 9

[Scott Collins]

170 hours is the magic number limit of Bonsai's memory?  Maybe a comment should
say that.  In any case, sr=scc.

Comment 10

[Simon Fraser [no longer active]]

No, 170 hours was pulled out of a hat (it's about a week). I just thought that 
doing a fast_update over any longer time-period than that was probably not 
reliable. I'm not sure how reliable bonsai is -- leaf/endico?

Comment 11

[Daniel (Leaf) Nunes]

i know there are at least a few checkins missing from the bonsai database that
would get missed if you went back all the way to the beginning of the bonsai
database, but other than the risk of missing those, i don't think there is time
limitation to the checkins that bonsai has tracked.

The unix version of fast-update.pl only checks the last 24 hours of changes, so
the concept of "last updated" being stored in the local tree is a vast improvement.

Comment 12

[Peter Van der Beken [:peterv]]

r=peterv

Comment 13

[Simon Fraser [no longer active]]

Attachment: Even better patch; deals with mozilla/netscape pulls

Comment 14

[Simon Fraser [no longer active]]

Attachment: ns/build/mac changes

Comment 15

[Simon Fraser [no longer active]]

The latest two patches are my Final Answer on this bug. They deal with storing 
the last pull date separately for mozilla and netscape pulls.

Comment 16

[Peter Van der Beken [:peterv]]

+    print(TIMESTAMP_FILE "# time of last checkout or update, in GMT. Use by
FAST_UPDATE\n");

should be

+    print(TIMESTAMP_FILE "# time of last checkout or update, in GMT. Used by
FAST_UPDATE\n");

Other than that, r=peterv.

Comment 17

[Scott Collins]

So all we need to put this into general practice is (a) to check these files in
and (b) to provide a build of MacCVS Pro that has the associated machinery?

Comment 18

[Simon Fraser [no longer active]]

Yes. I'll get a Mac CVS Pro 2.7d8 out (tho I think 2.7d7 has the necessary code). 
I guess I need to check that the MacCVS which is running is studly enough to 
support the fast_update.

Comment 19

[Scott Collins]

sr=scc on the most recent two attachments above (i.e., 41299 and 41300)

Comment 20

[Simon Fraser [no longer active]]

Checked in.

Comment 21

[Jon Granrose]

over to jj for verification.

Comment 22

[J.J. Enser]

verified