792815 - Update promise usage in gcli commands

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

We often use this:
let promise = context.createPromise();

To quote Joe:
That's sooooo 2012. The NEW IMPROVED way is:

var deferred = context.defer();
setTimeout(function() {
  deferred.resolve("hello");
}, 500);
return deferred.promise;

This should be updated across all gcli commands.

Comment 1

[Paul Rouget [:paul]]

Bug triage, filter on PINKISBEAUTIFUL

Comment 2

[Joe Walker [:jwalker]]

New component triage. Filter on "Lobster Thermidor aux crevettes with a Mornay sauce"

Comment 3

[Josh Marchán]

Attachment: v1

These are the only ones left. createPromise() can be safely removed from gcli after this patch.

Comment 4

[Joe Walker [:jwalker]]

Comment on attachment 731609 [details] [diff] [review]
v1

Review of attachment 731609 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent, thanks. I'll add this to my landing list.

Comment 5

[Josh Marchán]

woot! First accepted patch! Thanks! :)

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/8f2cda813c78

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8f2cda813c78