Closed
Bug 792815
Opened 13 years ago
Closed 12 years ago
Update promise usage in gcli commands
Categories
(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)
DevTools Graveyard
Graphic Commandline and Toolbar
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 23
People
(Reporter: miker, Assigned: sykopomp)
References
Details
Attachments
(1 file)
5.66 KB,
patch
|
jwalker
:
review+
|
Details | Diff | Splinter Review |
We often use this:
let promise = context.createPromise();
To quote Joe:
That's sooooo 2012. The NEW IMPROVED way is:
var deferred = context.defer();
setTimeout(function() {
deferred.resolve("hello");
}, 500);
return deferred.promise;
This should be updated across all gcli commands.
Reporter | ||
Updated•13 years ago
|
Status: NEW → ASSIGNED
Comment 1•12 years ago
|
||
Bug triage, filter on PINKISBEAUTIFUL
Component: Developer Tools: Inspector → Developer Tools
Comment 2•12 years ago
|
||
New component triage. Filter on "Lobster Thermidor aux crevettes with a Mornay sauce"
Component: Developer Tools → Developer Tools: Graphic Commandline and Toolbar
Reporter | ||
Updated•12 years ago
|
Assignee: mratcliffe → nobody
Assignee | ||
Comment 3•12 years ago
|
||
These are the only ones left. createPromise() can be safely removed from gcli after this patch.
Attachment #731609 -
Flags: review?(mratcliffe)
Attachment #731609 -
Flags: review?(jwalker)
Updated•12 years ago
|
Assignee: nobody → sykopomp
Comment 4•12 years ago
|
||
Comment on attachment 731609 [details] [diff] [review]
v1
Review of attachment 731609 [details] [diff] [review]:
-----------------------------------------------------------------
Excellent, thanks. I'll add this to my landing list.
Attachment #731609 -
Flags: review?(mratcliffe)
Attachment #731609 -
Flags: review?(jwalker)
Attachment #731609 -
Flags: review+
Updated•12 years ago
|
Whiteboard: [gclicommands] → [land-in-fx-team]
Assignee | ||
Comment 5•12 years ago
|
||
woot! First accepted patch! Thanks! :)
Comment 6•12 years ago
|
||
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 23
Updated•7 years ago
|
Product: Firefox → DevTools
Updated•7 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•