792833 - Don't unset current transaction until after savepoint has been released

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Found while looking at bug 792547. Basically the quota prompt will fail if we're in a savepoint release when the quota is exceeded. Simple patch.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/30ae02a8ce8c

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 663009 [details] [diff] [review]
Patch, v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Initial quota management implementation
User impact if declined: Crash and/or undefined behavior when a quota prompt is about to be displayed.
Testing completed (on m-c, etc.): m-i for now, m-c tomorrow
Risk to taking this patch (and alternatives if risky): This patch is exceptionally simple, almost guaranteed to be risk free.
String or UUID changes made by this patch: None

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/30ae02a8ce8c

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 663009 [details] [diff] [review]
Patch, v1

It's too late to take this on Beta and check for crash volume on something which has no crash signature or history of crashing so let's put this on Aurora and ride the train from there.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2593ecab46c6

Comment 6

[u279076]

Is there something QA can do to verify this fix?