Closed Bug 792833 Opened 7 years ago Closed 7 years ago

Don't unset current transaction until after savepoint has been released

Categories

(Core :: DOM: IndexedDB, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18
Tracking Status
firefox15 --- affected
firefox16 --- wontfix
firefox17 --- fixed
firefox18 --- fixed

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Details

(Whiteboard: [qa?])

Attachments

(1 file)

Attached patch Patch, v1Splinter Review
Found while looking at bug 792547. Basically the quota prompt will fail if we're in a savepoint release when the quota is exceeded. Simple patch.
Attachment #663009 - Flags: review?(khuey)
Comment on attachment 663009 [details] [diff] [review]
Patch, v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Initial quota management implementation
User impact if declined: Crash and/or undefined behavior when a quota prompt is about to be displayed.
Testing completed (on m-c, etc.): m-i for now, m-c tomorrow
Risk to taking this patch (and alternatives if risky): This patch is exceptionally simple, almost guaranteed to be risk free.
String or UUID changes made by this patch: None
Attachment #663009 - Flags: approval-mozilla-beta?
Attachment #663009 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/30ae02a8ce8c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Comment on attachment 663009 [details] [diff] [review]
Patch, v1

It's too late to take this on Beta and check for crash volume on something which has no crash signature or history of crashing so let's put this on Aurora and ride the train from there.
Attachment #663009 - Flags: approval-mozilla-beta?
Attachment #663009 - Flags: approval-mozilla-beta-
Attachment #663009 - Flags: approval-mozilla-aurora?
Attachment #663009 - Flags: approval-mozilla-aurora+
Is there something QA can do to verify this fix?
Whiteboard: [qa?]
You need to log in before you can comment on or make changes to this bug.