Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Don't unset current transaction until after savepoint has been released

RESOLVED FIXED in Firefox 17

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ben Turner (not reading bugmail, use the needinfo flag!), Assigned: Ben Turner (not reading bugmail, use the needinfo flag!))

Tracking

Trunk
mozilla18
Points:
---

Firefox Tracking Flags

(firefox15 affected, firefox16 wontfix, firefox17 fixed, firefox18 fixed)

Details

(Whiteboard: [qa?])

Attachments

(1 attachment)

Created attachment 663009 [details] [diff] [review]
Patch, v1

Found while looking at bug 792547. Basically the quota prompt will fail if we're in a savepoint release when the quota is exceeded. Simple patch.
Attachment #663009 - Flags: review?(khuey)
Attachment #663009 - Flags: review?(khuey) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/30ae02a8ce8c
Comment on attachment 663009 [details] [diff] [review]
Patch, v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Initial quota management implementation
User impact if declined: Crash and/or undefined behavior when a quota prompt is about to be displayed.
Testing completed (on m-c, etc.): m-i for now, m-c tomorrow
Risk to taking this patch (and alternatives if risky): This patch is exceptionally simple, almost guaranteed to be risk free.
String or UUID changes made by this patch: None
Attachment #663009 - Flags: approval-mozilla-beta?
Attachment #663009 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/30ae02a8ce8c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Comment on attachment 663009 [details] [diff] [review]
Patch, v1

It's too late to take this on Beta and check for crash volume on something which has no crash signature or history of crashing so let's put this on Aurora and ride the train from there.
Attachment #663009 - Flags: approval-mozilla-beta?
Attachment #663009 - Flags: approval-mozilla-beta-
Attachment #663009 - Flags: approval-mozilla-aurora?
Attachment #663009 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/2593ecab46c6
status-firefox15: --- → affected
status-firefox16: --- → wontfix
status-firefox17: --- → fixed
status-firefox18: --- → fixed
Is there something QA can do to verify this fix?
Whiteboard: [qa?]
You need to log in before you can comment on or make changes to this bug.