792887 - Out of memory when syncing tabs

Status: RESOLVED WORKSFORME

(Firefox :: Sync, defect)

Description

[Richard Newman [:rnewman]]

Thought I'd capture this. Sync is failing when extracting tabs.

Error creating record: [JavaScript Error: "out of memory" {file: "resource:///modules/sessionstore/SessionStore.jsm" line: 4153}] Stack trace: ssi_toJSONString()@resource:///modules/sessionstore/SessionStore.jsm:4153 < ssi_getBrowserState()@resource:///modules/sessionstore/SessionStore.jsm:1376 < ss_getBrowserState()@resource:///modules/sessionstore/SessionStore.jsm:111 < getAllTabs()@resource:///modules/services-sync/engines/tabs.js:128 < createRecord()@resource:///modules/services-sync/engines/tabs.js:169 < SyncEngine__createRecord()@resource://services-sync/engines.js:642

Comment 1

[Paul [pwd]]

This is such a weird one. I created a new profile and as I'm setting up the account, it gets to about 80/90% and then crashes. That's a fresh profile.

Is it possible some corrupted data in the cloud is causing this?

Comment 2

[Richard Newman [:rnewman]]

Not corruption in the usual sense; the payload would not be successfully decrypted if it wasn't identical to the data that a client uploaded.

Something might have changed in sessionstore to cause it to choke on data it previously produced.

And certainly nothing Sync does (outside of js-ctypes crypto) should ever cause Firefox to crash.

Can you provide a log from the crash? about:crashes might have a record.

Comment 3

[Paul [pwd]]

All about:crashes logs are coming up empty, but nonetheless:
http://crash-stats.mozilla.com/report/index/bp-f9571c8b-7d1f-4989-9d5e-765362120922
http://crash-stats.mozilla.com/report/index/bp-f8f5e19f-e5bb-4dc4-b862-7f4162120922
http://crash-stats.mozilla.com/report/index/bp-1667daab-0c6a-4cb4-900a-6c06b2120922
http://crash-stats.mozilla.com/report/index/bp-ad00eceb-8796-496a-b409-b6c562120922
http://crash-stats.mozilla.com/report/index/bp-cadf62fb-51fb-46ca-95b1-213452120922

Comment 4

[Paul [pwd]]

Attachment: Sync Log 01

Comment 5

[Paul [pwd]]

Attachment: Sync Log 02

Comment 6

[Paul [pwd]]

Attachment: Sync Log 03

Comment 7

[Paul [pwd]]

Attachment: Sync Log 04

Comment 8

[Paul [pwd]]

Attachment: Sync Log 05

Comment 9

[Paul [pwd]]

I seemingly had a bit of a respite with a new profile. However yesterday, since adding my phone back to my sync account, I've had constant crashes again.

Comment 10

[Richard Newman [:rnewman]]

Do you still get crashes if you uncheck Tabs in Sync Preferences?

Comment 11

[Paul [pwd]]

I'm still getting failures with Sync. Though the last one didn't cause a crash. That said, it's started crashing my Fennec.

Thought this may be of interest:

1349302616890	Sync.Store.Bookmarks	WARN	Failed to apply incoming record XDm7X8_JlBH9
1349302616890	Sync.Store.Bookmarks	WARN	Encountered exception: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.insertBookmark] Stack trace: BStore_create()@resource:///modules/services-sync/engines/bookmarks.js:637 < Store_applyIncoming()@resource://services-sync/engines.js:239 < BStore_applyIncoming()@resource:///modules/services-sync/engines/bookmarks.js:525 < applyIncomingBatch()@resource://services-sync/engines.js:207 < doApplyBatch()@resource://services-sync/engines.js:759 < resource://services-sync/engines.js:866 < resource://services-sync/record.js:608 < Channel_onDataAvail()@resource:///modules/services-sync/resource.js:522 < <file:unknown>

1349302616897	Sync.Engine.History	INFO	162 outgoing items pre-reconciliation
1349302623691	Sync.Engine.History	WARN	DATA LOSS: Both local and remote changes to record: --GFCski7uAv
1349302623842	Sync.Engine.History	WARN	DATA LOSS: Both local and remote changes to record: -4DKqSqEXFZr
1349302623893	Sync.Engine.History	WARN	DATA LOSS: Both local and remote changes to record: -7PmNFOz-cyi
1349302624212	Sync.Engine.History	WARN	DATA LOSS: Both local and remote changes to record: -MfUgHyZ-Q-v
1349302624252	Sync.Engine.History	WARN	DATA LOSS: Both local and remote changes to record: -PebbcvWUjYU
1349302624411	Sync.Engine.History	WARN	DATA LOSS: Both local and remote changes to record: -XmD4ddhq1Sv
1349302625202	Sync.Engine.History	WARN	DATA LOSS: Both local and remote changes to record: 0DwxkHNVyTq9
1349302627408	Sync.Engine.History	WARN	DATA LOSS: Both local and remote changes to record: 13u-0ojEfMtK
1349302628232	Sync.Status	DEBUG	Status for engine history: error.engine.reason.unknown_fail
1349302628232	Sync.Status	DEBUG	Status.service: success.status_ok => error.sync.failed_partial
1349302628232	Sync.ErrorHandler	DEBUG	history failed: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS JS Stack trace: [e-mail]:400 < [e-mail]:873 < [e-mail]:1284 < [e-mail]:142 < [e-mail]:481 < [e-mail]:1399 < [e-mail]:1292 < [e-mail]:142 < [e-mail]:97 < [e-mail]:1192 < @service.js:1183 < [e-mail]:71 < [e-mail]:1171

Comment 12

[Paul [pwd]]

Tried turning off bookmark syncing too. Still seeing the issue sadly.

Comment 13

[Richard Newman [:rnewman]]

(In reply to Paul [sabret00the] from comment #12)
> Tried turning off bookmark syncing too. Still seeing the issue sadly.

Still seeing which issue?

Comment 14

[Paul [pwd]]

Everything on the browser turns black before it crashes.

Comment 15

[Richard Newman [:rnewman]]

So you're saying that with Tabs and Bookmarks both unchecked, desktop's entire chrome UI goes black and the process dies during your sync?

Comment 16

[Paul [pwd]]

Not the chrome, the actual page. I'll have one of four things happen.

1. Sync encounters error, toast pops up, page goes black and I have to change tab to restore the content

2. Sync encounters error, toast pops up, page goes black and chrome turns completely to glass (tabs disappear, even the toast is glass) and I can guess where the X is, click it and continue browsing when the chrome reappears).

3. Sync encounters error, toast pops up, page goes black and Firefox crashes with an empty report.


4. Sync encounters error, toast pops up, page goes black and chrome turns completely to glass (tabs disappear, even the toast is glass) and then Firefox crashes with an empty crash report.

Comment 17

[Paul [pwd]]

If there's anything from about:memory I can add, be sure to let me know what. Also if there's an extension I can install to help diagnose this, I'd be happy to install that too.

Comment 18

[Paul [pwd]]

I removed my mobile profile (uninstalled) and created a new one. And now every time Fennec tries an initial sync, Fennec crashes. I say that but this could also be bug 798858

Comment 19

[Paul [pwd]]

Attachment: aLogCat taken directly after uncaught crash

Comment 20

[Richard Newman [:rnewman]]

(In reply to Paul [sabret00the] from comment #18)
> I removed my mobile profile (uninstalled) and created a new one. And now
> every time Fennec tries an initial sync, Fennec crashes.

Well, it's not this bug for sure. Please file a new bug in Fennec, attaching this log; the PasswordsProvider is crashing.

Pretty much nothing Sync can do on Android can cause a 'real' crash like that.

> I say that but this
> could also be bug 798858

Did you typo that bug number? Looks like a very different bug.

Comment 21

[Paul [pwd]]

Filed as bug 799141. That was indeed the bug I thought it may have been as an alternative as that bug stopped me from opening the last build of Fennec at all.

Comment 22

[Paul [pwd]]

Disabled HW acceleration and the chrome issues have gone. Now I'm just getting Sync failing which is bogging down nightly and also crashing on occasion but not as much as with HWA on.

Comment 23

[Paul [pwd]]

Attachment: Sync Log 06

Here's the latest sync-log. I think this one may actually be a tad more helpful.

Comment 24

[Paul [pwd]]

I'm not getting messages to say that Sync hasn't completed in seven days.

Comment 25

[Paul [pwd]]

Thought it worth mentioning that Firefox 16.1 is working. No crashes and syncing properly.

Comment 26

[Paul [pwd]]

Aurora 17.0a2 doesn't seem to have the problem either.

Comment 27

[Richard Newman [:rnewman]]

Paul: this is spiraling into multiple bugs.

Please file a new bug with the log from Comment 23, and CC :mak. Extra points if you can reproduce that log with history logging set to Trace.

If you're agreed that you're not seeing OOM when syncing tabs, we'll close this one as WFM.

Comment 28

[Paul [pwd]]

Go for it. And thanks for all the help Richard. I've actually managed to figure this all out BTW. The issue was caused by three extensions not being presented for installation on Nightly. They were re-presented when I checked with RTM. The extensions were Skype and two Java extensions. For some unknown reason they don't appear on Nightly or Aurora, but they were causing the issues. Since they were given the OK on 16, all issues have subsided. I have no idea how to file a bug to flag this issue though.

Comment 29

[Richard Newman [:rnewman]]

Thanks Paul.