Grid layout is slightly off and can't be scrolled

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

Trunk
x86_64
Windows 8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: completed-elm)

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

6 years ago
These patches fix a few things:

- The grid layout was over estimating the number of items that can fit in a row. Nine bookmarks on the samsung tablet will reproduce the problem.

- Added inputProcessing support for various StartUI elements so that scrolling now works.

- Added 'Bookmarks' and 'Downloads' label links. Note in the design comps we also have entries such as "More Bookmarks" at the end of each set. These links have yet to be implemented.

- Added some debug labels to grid for easier debugging
(Assignee)

Comment 1

6 years ago
Created attachment 663064 [details] [diff] [review]
patch v.1
Assignee: nobody → jmathies
(Assignee)

Comment 2

6 years ago
Created attachment 663065 [details] [diff] [review]
history.js line endings
(Assignee)

Updated

6 years ago
Attachment #663064 - Flags: review?(mbrubeck)
(Assignee)

Updated

6 years ago
Attachment #663065 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Blocks: 793502
Comment on attachment 663064 [details] [diff] [review]
patch v.1

I don't like that setting the "gridName" property has the non-obvious side effect of making arrangeItems work or not work depending on the value.  Could you change <property name="gridName"> to <method name="init"> and pass in the name as a parameter?  That should make it clearer that init() must be called when setting up the grid.
Attachment #663064 - Flags: review?(mbrubeck) → review+
(Assignee)

Updated

6 years ago
Attachment #663064 - Attachment is obsolete: true
Attachment #663064 - Flags: review+
(Assignee)

Comment 4

6 years ago
Created attachment 664430 [details] [diff] [review]
remove crlf from grid.xml
(Assignee)

Comment 5

6 years ago
Created attachment 664431 [details] [diff] [review]
grid fixes v.1
(Assignee)

Comment 6

6 years ago
Comment on attachment 664431 [details] [diff] [review]
grid fixes v.1

- added various ids, get rid of 'gridName'
- fixup arrangeItems for autocomplete
- dismiss the app bar when autocomplete is displayed
- added commenting
- added inputProcessing attribute for scrolling
Attachment #664431 - Flags: review?(mbrubeck)
(Assignee)

Updated

6 years ago
Blocks: 747789
Attachment #664431 - Flags: review?(mbrubeck) → review+
(Assignee)

Updated

6 years ago
Whiteboard: completed-elm
(Assignee)

Updated

6 years ago
Component: General → General
Product: Firefox → Firefox for Metro
Depends on: 799230
Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.