Last Comment Bug 792965 - Add icons to compose autocomplete list
: Add icons to compose autocomplete list
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Thunderbird 18.0
Assigned To: Richard Marti (:Paenglab)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-20 12:57 PDT by Richard Marti (:Paenglab)
Modified: 2012-10-01 16:21 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (3.71 KB, patch)
2012-09-20 13:03 PDT, Richard Marti (:Paenglab)
no flags Details | Diff | Review
patch (3.71 KB, patch)
2012-09-20 13:05 PDT, Richard Marti (:Paenglab)
bwinton: review+
bwinton: ui‑review+
Details | Diff | Review
screenshot (3.36 KB, image/png)
2012-09-20 13:09 PDT, Richard Marti (:Paenglab)
no flags Details

Description Richard Marti (:Paenglab) 2012-09-20 12:57:10 PDT
The address autocomplete list lacks icons on Linux/Windows. OSX has the icons.
Comment 1 Richard Marti (:Paenglab) 2012-09-20 13:03:24 PDT
Created attachment 663121 [details] [diff] [review]
patch

I haven't took the treechildren::-moz-tree-cell-text(default-match) rule the OSX theme is using because I'm seeing no difference with or without this. I also don't know when this is used.
Comment 2 Richard Marti (:Paenglab) 2012-09-20 13:05:19 PDT
Created attachment 663123 [details] [diff] [review]
patch

Oops, forgot to enter the bug number in patch.
Comment 3 Richard Marti (:Paenglab) 2012-09-20 13:09:03 PDT
Created attachment 663129 [details]
screenshot

Screenshot under Win7 for easier ui-r. I made the icons/text align with the ones in textfield. XP and Linux are looking similar.
Comment 4 Blake Winton (:bwinton) (:☕️) 2012-10-01 08:24:04 PDT
Comment on attachment 663123 [details] [diff] [review]
patch

Yeah, I think I like this patch.  And there's nothing wrong with the code either, so r=me, and ui-r=me.

Thanks,
Blake.
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-10-01 16:21:20 PDT
https://hg.mozilla.org/comm-central/rev/aa97a4759ab2

Note You need to log in before you can comment on or make changes to this bug.