Add icons to compose autocomplete list

RESOLVED FIXED in Thunderbird 18.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 18.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
The address autocomplete list lacks icons on Linux/Windows. OSX has the icons.
(Assignee)

Comment 1

5 years ago
Created attachment 663121 [details] [diff] [review]
patch

I haven't took the treechildren::-moz-tree-cell-text(default-match) rule the OSX theme is using because I'm seeing no difference with or without this. I also don't know when this is used.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #663121 - Flags: ui-review?(bwinton)
Attachment #663121 - Flags: review?(bwinton)
(Assignee)

Comment 2

5 years ago
Created attachment 663123 [details] [diff] [review]
patch

Oops, forgot to enter the bug number in patch.
Attachment #663121 - Attachment is obsolete: true
Attachment #663121 - Flags: ui-review?(bwinton)
Attachment #663121 - Flags: review?(bwinton)
Attachment #663123 - Flags: ui-review?(bwinton)
Attachment #663123 - Flags: review?(bwinton)
(Assignee)

Comment 3

5 years ago
Created attachment 663129 [details]
screenshot

Screenshot under Win7 for easier ui-r. I made the icons/text align with the ones in textfield. XP and Linux are looking similar.
Comment on attachment 663123 [details] [diff] [review]
patch

Yeah, I think I like this patch.  And there's nothing wrong with the code either, so r=me, and ui-r=me.

Thanks,
Blake.
Attachment #663123 - Flags: ui-review?(bwinton)
Attachment #663123 - Flags: ui-review+
Attachment #663123 - Flags: review?(bwinton)
Attachment #663123 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/aa97a4759ab2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
You need to log in before you can comment on or make changes to this bug.