793011 - Bad error message when adding a typedef name to Bindings.conf

Status: RESOLVED DUPLICATE of bug 792980

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

Add a webidl file containing this:

interface mozFoo {};
typedef mozFoo Foo;

And in Bindings.conf, add and entry for "Foo" (not "mozFoo").  Here's what you'll end up getting:

Traceback (most recent call last):
  File "/Users/ehsanakhgari/moz/mozilla-central/config/pythonpath.py", line 56, in <module>
    main(sys.argv[1:])
  File "/Users/ehsanakhgari/moz/mozilla-central/config/pythonpath.py", line 48, in main
    execfile(script, frozenglobals)
  File "/Users/ehsanakhgari/moz/mozilla-central/dom/bindings/GlobalGen.py", line 80, in <module>
    main()
  File "/Users/ehsanakhgari/moz/mozilla-central/dom/bindings/GlobalGen.py", line 67, in main
    config = Configuration(configFile, parserResults)
  File "/Users/ehsanakhgari/moz/mozilla-central/dom/bindings/Configuration.py", line 34, in __init__
    self.descriptors.extend([Descriptor(self, iface, x) for x in entry])
  File "/Users/ehsanakhgari/moz/mozilla-central/dom/bindings/Configuration.py", line 131, in __init__
    if self.interface.isExternal() or self.interface.isCallback():
AttributeError: 'IDLTypedefType' object has no attribute 'isExternal'
make[6]: *** [ParserResults.pkl] Error 1
make[6]: *** Deleting file `ParserResults.pkl'
make[5]: *** [bindings_export] Error 2
make[4]: *** [export_tier_platform] Error 2
make[3]: *** [tier_platform] Error 2
make[2]: *** [default] Error 2
make[1]: *** [realbuild] Error 2
make: *** [build] Error 2

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Ugh.

I think we should replace

26             if not thing.isInterface(): continue

with

if not isInstance(thing, IDLInterface): continue

because types have an isInterface method, and will test True if they are interface types.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Fun.  Yeah, makes sense to me.  Kyle, want to patch?  I'll review.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 663557 [details] [diff] [review]
Patch

r=me.  I ended up doing more or less the same in bug 792980...

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Ok, we can just land your patch then.  No point in bitrotting you.

Comment 6

[Boris Zbarsky [:bzbarsky]]

I'm fine with this landing now and merging as needed, fwiw.  That other patch might take some convincing to get reviews...