Closed Bug 793156 Opened 13 years ago Closed 11 years ago

[ACR] Observer not being removed will cause leak

Categories

(addons.mozilla.org Graveyard :: Compatibility Tools, defect, P2)

Product:
addons.mozilla.org Graveyard
Component:
Compatibility Tools
Platform:
x86
All
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kinger, Assigned: kmag)

References

Details

Kris reported: Its about:addons ChromeMod adds an observer that it doesn't remove, which will cause a slow leak.
Kris, We had a look at the chrome mod code - the observers look like they are being removed. Any more details? (note I'll be pushing out a new RC build today and will notify you, you may want to wait for that first)
Assignee: nobody → kmaglione+bmo
Sorry, I can see how my description of the problem might have been ambiguous. chrome-mod.js is fine. The problem is the ChromeMod instance for about:addons which adds a new observer every time about:addons is opened: https://github.com/brianking/ACR/blob/master/lib/main.js#L71
Not sure why this was assigned to me.
Assignee: kmaglione+bmo → nobody
Well, I guess I own the ACR now, so I'll take this.
Assignee: nobody → kmaglione+bmo
Fixed in 3.0.2, currently pending review on AMO.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.