793197 - Multiple selection dropdown listbox options are not visible [ICS] [JB]

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ioana Chiorean]

Attachment: Screenshot - new display - options are not visible

Build ID: 18.0 (2012-09-22) Nightly Channel
Device:  Galaxy Nexus 
OS: 4.1.1

Steps to reproduce:
1. Open Fennec -> go to bugzila.mozilla.org -> search - Advance tab
2. Tap on Product options - pan the list 

Actual results:
- Multiple selection dropdown listbox options are not visible 
- reproducible on other sites with multiple selection dropdown listbox 
- reproducible only on JB and ICS Android OS 

Expected results:
- Multiple selection dropdown listbox options should be visible

Comment 1

[Wesley Johnston (:wesj)]

This was caused by bug 785994. Looking into a fix....

Comment 2

[Henri Sivonen (:hsivonen)]

Nominating for tracking, since this is major loss of functionality on Web forms that use <select multiple>.

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

I'm not quite sure why we have this listViewStyle. Is it required for devices with a hardware menu button? This seems fine to me, but I'd like to understand a bit better where this should show up.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 664716 [details] [diff] [review]
Patch

Oh please no! This listViewStyle is used by custom menu. And we are moving towards this approach of specifying a "common" style at application/activity level. I'll fix it in Prompt in a different way.

Comment 5

[Wesley Johnston (:wesj)]

sriram, just tell me how you want it fixed if you want. I think the alternative is to write a custom style for these list items?

Comment 7

[Wesley Johnston (:wesj)]

Attachment: Patch v2

I really hate that we're not just using native styles, but if we're not we need to override the textColor in this layout. This is a simple way to do that, and I think we want this fixed before we branch next week.

Comment 8

[Sriram Ramasubramanian [:sriram]]

(In reply to Wesley Johnston (:wesj) from comment #7)
> Created attachment 667082 [details] [diff] [review]
> Patch v2
> 
> I really hate that we're not just using native styles, but if we're not we
> need to override the textColor in this layout. This is a simple way to do
> that, and I think we want this fixed before we branch next week.

I would be happy to use default views given by Android in that case -- without we ourselves calling android.R.layout.something. In which case, we don't have to override anything.

Comment 9

[Wesley Johnston (:wesj)]

Attachment: Patch v2

Whoops. Missed disabled item styling. Also broke pre-gingerbread phones. This fixes both for me. I'll post screenshots from both devices.

Comment 10

[Wesley Johnston (:wesj)]

Attachment: Screenshot GB with a Motorola theme

Comment 11

[Wesley Johnston (:wesj)]

Attachment: Screenshot Nexus 7 (stock JB)

Comment 12

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 667163 [details] [diff] [review]
Patch v2

Review of attachment 667163 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.

Comment 13

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0b9c37de03a2

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0b9c37de03a2