Closed Bug 793219 Opened 7 years ago Closed 7 years ago

DOM Bluetooth code uses nsresults where it means bools

Categories

(Core :: DOM: Device Interfaces, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

/builds/slave/try-ics-armv7a-gecko/build/dom/bluetooth/ipc/BluetoothParent.cpp: In member function 'bool mozilla::dom::bluetooth::BluetoothRequestParent::DoRequest(const mozilla::dom::bluetooth::SetPinCodeRequest&)':
/builds/slave/try-ics-armv7a-gecko/build/dom/bluetooth/ipc/BluetoothParent.cpp:401: error: cannot convert 'bool' to 'nsresult' in initialization
/builds/slave/try-ics-armv7a-gecko/build/dom/bluetooth/ipc/BluetoothParent.cpp: In member function 'bool mozilla::dom::bluetooth::BluetoothRequestParent::DoRequest(const mozilla::dom::bluetooth::SetPasskeyRequest&)':
/builds/slave/try-ics-armv7a-gecko/build/dom/bluetooth/ipc/BluetoothParent.cpp:417: error: cannot convert 'bool' to 'nsresult' in initialization
/builds/slave/try-ics-armv7a-gecko/build/dom/bluetooth/ipc/BluetoothParent.cpp: In member function 'bool mozilla::dom::bluetooth::BluetoothRequestParent::DoRequest(const mozilla::dom::bluetooth::ConfirmPairingConfirmationRequest&)':
/builds/slave/try-ics-armv7a-gecko/build/dom/bluetooth/ipc/BluetoothParent.cpp:434: error: cannot convert 'bool' to 'nsresult' in initialization
/builds/slave/try-ics-armv7a-gecko/build/dom/bluetooth/ipc/BluetoothParent.cpp: In member function 'bool mozilla::dom::bluetooth::BluetoothRequestParent::DoRequest(const mozilla::dom::bluetooth::ConfirmAuthorizationRequest&)':
/builds/slave/try-ics-armv7a-gecko/build/dom/bluetooth/ipc/BluetoothParent.cpp:450: error: cannot convert 'bool' to 'nsresult' in initialization
/builds/slave/try-ics-armv7a-gecko/build/dom/bluetooth/ipc/BluetoothParent.cpp: In member function 'bool mozilla::dom::bluetooth::BluetoothRequestParent::DoRequest(const mozilla::dom::bluetooth::DenyPairingConfirmationRequest&)':
/builds/slave/try-ics-armv7a-gecko/build/dom/bluetooth/ipc/BluetoothParent.cpp:467: error: cannot convert 'bool' to 'nsresult' in initialization
/builds/slave/try-ics-armv7a-gecko/build/dom/bluetooth/ipc/BluetoothParent.cpp: In member function 'bool mozilla::dom::bluetooth::BluetoothRequestParent::DoRequest(const mozilla::dom::bluetooth::DenyAuthorizationRequest&)':
/builds/slave/try-ics-armv7a-gecko/build/dom/bluetooth/ipc/BluetoothParent.cpp:483: error: cannot convert 'bool' to 'nsresult' in initialization
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #663453 - Flags: review?(kyle)
Attachment #663453 - Flags: review?(kyle) → review?(dhylands)
Component: DOM → DOM: Device Interfaces
Attachment #663453 - Flags: review?(dhylands) → review+
Double-landed on central:
https://hg.mozilla.org/mozilla-central/rev/1b82c517055d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.