Closed
Bug 793231
Opened 13 years ago
Closed 13 years ago
add text_phrase queries to search
Categories
(support.mozilla.org :: Search, defect, P1)
support.mozilla.org
Search
Tracking
(Not tracked)
RESOLVED
FIXED
2012Q3
People
(Reporter: willkg, Assigned: willkg)
Details
(Whiteboard: u=user c=search p=1)
Spinning this out of bug #791250.
"""
Pretty sure the first would be solved nicely by adding text_phrase queries to the search. That's something that would benefit normal searches, too. It'd increase the scores for documents where the words show up in the document in the same vicinity in the same order as a phrase. That's probably a half-day to implement.
"""
This covers adding text_phrase queries in addition to text queries to searches.
Might as well add fuzzy queries and prefix queries as well since AMO does that.
Two things to note:
1. adding more queries increases the time it takes for ES to calculate search results
2. this will make the explain data really long and involved
Assignee | ||
Comment 1•13 years ago
|
||
I'm pretty sure this is a 1 point bug. The changes are to one specific place in the search view code and all that's involved is adding a few more query types.
Making it a P1 because the current CTR sucks.
Grabbing it to work on today.
Assignee: nobody → willkg
Priority: -- → P1
Whiteboard: u=user c=search p=1
Assignee | ||
Comment 2•13 years ago
|
||
Matt: Can I get a list of the searches you were using to compare bucketed and unified search?
Comment 3•13 years ago
|
||
Hey Will. I'm adding Cheng as well since he is the one that pulled that list for me. I'm not sure how much it will help in testing this change though since it is predominantly single word searches.
Assignee | ||
Comment 4•13 years ago
|
||
In a pull request: https://github.com/mozilla/kitsune/pull/858
Comment 5•13 years ago
|
||
Hey Will. I had a chance to look at the comparisons that you gave me and initial results look good. Ricky and I spoke earlier today and discussed enabling it for a week and using CTR as our gauge. After looking at the results you showed me earlier today, I'm comfortable with making that change. Thanks again!
Assignee | ||
Comment 6•13 years ago
|
||
Landed in master in https://github.com/mozilla/kitsune/commit/6be3f371cf1cd84259f7bbc2f62dd42f2c432061
Pushed to production by Ricky just now.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2012Q3
You need to log in
before you can comment on or make changes to this bug.
Description
•