793243 - Eng builds (VARIANT=) fail to show homescreen on otoro

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Dave Hylands [:dhylands]]

If you do a VARIANT= (i.e. eng build) for otoro, then the homescreen fails to load, if the phone was just flashed using ./flash.sh

Using "./flash.sh gecko" with the same image works.

The problem boils down to code somewhere trying to create the /system/b2g/webapps directory. On a boot after ./flash, /system is on a RO filesystem, so creating that directory is guaranteed to fail.

I see the following messages in logcat (the nsLocalFile::CreateAndKeepOpen: create of '/system/b2g/webapps' failed: 30 line was a print added in my tree):

nsLocalFile::CreateAndKeepOpen: create of '/system/b2g/webapps' failed: 30
[JavaScript Error: "DOMApplicationRegistry: Could not parse JSON: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsILocalFile.create]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/FileUtils.jsm :: FileUtils_getDir :: line 67"  data: no]" {file: "resource://gre/modules/Webapps.jsm" line: 364}]
nsLocalFile::CreateAndKeepOpen: create of '/system/b2g/webapps' failed: 30
[JavaScript Error: "[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsILocalFile.create]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/FileUtils.jsm :: FileUtils_getDir :: line 67"  data: no]" {file: "resource://gre/modules/FileUtils.jsm" line: 67}]

and later on, I see:

[JavaScript Error: "DOMApplicationRegistry: Could not read from /system/b2g/webapps/webapps.json : [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIChannel.asyncOpen]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: resource://gre/modules/NetUtil.jsm :: NetUtil_asyncOpen :: line 165"  data: no]" {file: "resource://gre/modules/Webapps.jsm" line: 371}]

Comment 1

[Dave Hylands [:dhylands]]

Attachment: Backtraces

Comment 2

[[:fabrice] Fabrice Desré]

Attachment: patch

getFile() calls getDir() with shouldCreate = true...

Comment 3

[Dave Hylands [:dhylands]]

The patch gets rid of the 3rd warning in logcat, but I still don't applications populated on the homescreen until I do: ./flash.sh gecko.

If I do the following:

./flash.sh
and then do 
adb remount
right after the time is set, then I get apps populated.

Comment 4

[[:fabrice] Fabrice Desré]

Attachment: patch v2

Better patch, with a missing call to registerAppsHandler() in some cases.

I tested with:
- VARIANT=user
- no VARIANT
- linux desktop build

They all started and rebooted fine.

Comment 5

[Dave Hylands [:dhylands]]

Comment on attachment 663620 [details] [diff] [review]
patch v2

Review of attachment 663620 [details] [diff] [review]:
-----------------------------------------------------------------

Yep - I also tested VARIANT= and it works for me too!

Comment 6

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f6472d712439

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f6472d712439