Closed
Bug 793322
Opened 12 years ago
Closed 12 years ago
Troubleshoot.jsm test should fail immediately instead of timing out on snapshot data validation errors
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(1 file)
|
974 bytes,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
validateObject throws an exception on validation failure. When that happens, done is never called and the test ends up timing out. The exception should be caught and reported as a failure, and then the test should continue.
Attachment #663576 -
Flags: review?(felipc)
|
||
Updated•12 years ago
|
Attachment #663576 -
Flags: review?(felipc) → review+
|
Assignee | |
Comment 1•12 years ago
|
||
Thanks for the quick review. https://hg.mozilla.org/integration/mozilla-inbound/rev/046968d6f256
Flags: in-testsuite+
|
||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/046968d6f256
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•