Closed
Bug 79336
Opened 24 years ago
Closed 23 years ago
javascript strict warnings in findUtils.js
Categories
(SeaMonkey :: Search, defect, P4)
SeaMonkey
Search
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0.1
People
(Reporter: bugzilla, Assigned: samir_bugzilla)
Details
(Keywords: helpwanted)
Attachments
(2 files)
|
870 bytes,
patch
|
samir_bugzilla
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
|
729 bytes,
patch
|
samir_bugzilla
:
review+
|
Details | Diff | Splinter Review |
JavaScript strict warning:
chrome://communicator/content/findUtils.js line 39: reference to undefined
property window.findDialog
build 20010507
|
||
Comment 1•24 years ago
|
||
We need a if ("findDialog" in window && window.findDialog)
|
||
Comment 2•24 years ago
|
||
reassign-->samir
Assignee: matt → sgehani
Priority: -- → P4
Target Milestone: --- → mozilla0.9.5
|
|
Assignee | |
Comment 3•24 years ago
|
||
Henrik,
Would you have time to come up with patches for all these search-related js
strict-mode warnings? I can check them in for you. Thanks.
|
|
Assignee | |
Updated•24 years ago
|
Target Milestone: mozilla0.9.5 → Future
|
|
Assignee | |
Comment 4•24 years ago
|
||
|
|
Assignee | |
Comment 5•24 years ago
|
||
Comment on attachment 52078 [details] [diff] [review]
Simon's patch
r=sgehani
Attachment #52078 -
Flags: review+
|
|
Assignee | |
Comment 6•24 years ago
|
||
dveditz, please rs.
Status: NEW → ASSIGNED
Target Milestone: Future → mozilla0.9.6
|
|
Assignee | |
Comment 7•24 years ago
|
||
mscott, please rs.
|
|
Assignee | |
Comment 8•24 years ago
|
||
alecf, please rs.
|
|
||
Comment 9•24 years ago
|
||
Comment on attachment 52078 [details] [diff] [review]
Simon's patch
sr=alecf
Attachment #52078 -
Flags: superreview+
|
|
Assignee | |
Updated•24 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 10•24 years ago
|
||
Checked in.
|
Reporter | |
Comment 11•23 years ago
|
||
Warning: reference to undefined property window.findDialog
Source File: chrome://communicator/content/findUtils.js
Line: 65
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Updated•23 years ago
|
Target Milestone: mozilla0.9.6 → mozilla1.0.1
|
||
Comment 12•23 years ago
|
||
|
|
Assignee | |
Comment 13•23 years ago
|
||
Comment on attachment 60571 [details] [diff] [review]
same patch as smfr's; fix 2nd instance of if (window.findDialog)
r=sgehani
Attachment #60571 -
Flags: review+
|
||
Updated•23 years ago
|
Keywords: mozilla0.9.8
|
|
||
Comment 14•23 years ago
|
||
alecf: can you sr?
|
|
||
Comment 15•23 years ago
|
||
Comment on attachment 60571 [details] [diff] [review]
same patch as smfr's; fix 2nd instance of if (window.findDialog)
sr=alecf
|
|
||
Comment 16•23 years ago
|
||
marking fixed. stephend checked in the patch for me.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 23 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 18•23 years ago
|
||
in the "The never ending story about strict warnings" I now see:
Warning: function findAgainInPage does not always return a value
Source File: chrome://communicator/content/findUtils.js
Line: 106
Source Code:
}
Should I reopen or open a bug bug?
|
|
Assignee | |
Comment 19•23 years ago
|
||
New bug please.
|
|
Reporter | |
Comment 20•23 years ago
|
||
bug 133675 opened with the new strict warning
|
||
Updated•17 years ago
|
Product: Core → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•