javascript strict warnings in findUtils.js

VERIFIED FIXED in mozilla1.0.1

Status

P4
normal
VERIFIED FIXED
18 years ago
10 years ago

People

(Reporter: bugzilla, Assigned: samir_bugzilla)

Tracking

({helpwanted})

Trunk
mozilla1.0.1
helpwanted

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

18 years ago
JavaScript strict warning:
chrome://communicator/content/findUtils.js line 39: reference to undefined 
property window.findDialog

build 20010507

Comment 1

18 years ago
We need a if ("findDialog" in window && window.findDialog)

Comment 2

17 years ago
reassign-->samir
Assignee: matt → sgehani
Priority: -- → P4
Target Milestone: --- → mozilla0.9.5
(Assignee)

Comment 3

17 years ago
Henrik,
Would you have time to come up with patches for all these search-related js
strict-mode warnings?  I can check them in for you.  Thanks.

(Assignee)

Updated

17 years ago
Target Milestone: mozilla0.9.5 → Future
(Assignee)

Comment 4

17 years ago
Created attachment 52078 [details] [diff] [review]
Simon's patch
(Assignee)

Comment 5

17 years ago
Comment on attachment 52078 [details] [diff] [review]
Simon's patch

r=sgehani
Attachment #52078 - Flags: review+
(Assignee)

Comment 6

17 years ago
dveditz, please rs.  
Status: NEW → ASSIGNED
Target Milestone: Future → mozilla0.9.6
(Assignee)

Updated

17 years ago
Keywords: patch
(Assignee)

Updated

17 years ago
Keywords: review
(Assignee)

Comment 7

17 years ago
mscott, please rs.
(Assignee)

Comment 8

17 years ago
alecf, please rs.

Comment 9

17 years ago
Comment on attachment 52078 [details] [diff] [review]
Simon's patch

sr=alecf
Attachment #52078 - Flags: superreview+
(Assignee)

Updated

17 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Assignee)

Comment 10

17 years ago
Checked in.
(Reporter)

Comment 11

17 years ago
Warning: reference to undefined property window.findDialog
Source File: chrome://communicator/content/findUtils.js
Line: 65
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

17 years ago
Keywords: patch, review → helpwanted
Target Milestone: mozilla0.9.6 → mozilla1.0.1

Comment 12

17 years ago
Created attachment 60571 [details] [diff] [review]
same patch as smfr's; fix 2nd instance of if (window.findDialog)
(Assignee)

Comment 13

17 years ago
Comment on attachment 60571 [details] [diff] [review]
same patch as smfr's; fix 2nd instance of if (window.findDialog)

r=sgehani
Attachment #60571 - Flags: review+

Updated

17 years ago
Keywords: review

Updated

17 years ago
Keywords: mozilla0.9.8

Comment 14

17 years ago
alecf: can you sr?

Comment 15

17 years ago
Comment on attachment 60571 [details] [diff] [review]
same patch as smfr's; fix 2nd instance of if (window.findDialog)

sr=alecf

Comment 16

17 years ago
marking fixed. stephend checked in the patch for me.
Status: REOPENED → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 17

17 years ago
verified fixed in 20020115
Status: RESOLVED → VERIFIED
(Reporter)

Comment 18

17 years ago
in the "The never ending story about strict warnings" I now see:

Warning: function findAgainInPage does not always return a value
Source File: chrome://communicator/content/findUtils.js
Line: 106
Source Code:
}

Should I reopen or open a bug bug?
(Assignee)

Comment 19

17 years ago
New bug please.
(Reporter)

Comment 20

17 years ago
bug 133675 opened with the new strict warning
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.