793423 - B2G RIL: Remove 'system-app-ready' mozContentEvent dependency

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Bug 793082 introduced a generalized mozChromeEvent sender in place that will wait for System app to load. We can go ahead and remove the 'system-app-ready' mozContentEvent dependency introduced in bug 787172. 

philikon, can this be done by simply revert attachment 657004 [details] [diff] [review]? How do I verify the case you tried so solve in bug 787172 still works?

After this bug is fixed, 'system-app-ready' mozContentEvent in Gaia can be removed.

Comment 1

[Philipp von Weitershausen [:philikon]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #0)
> philikon, can this be done by simply revert attachment 657004 [details] [diff] [review]
> [diff] [review]?

It should be, yes.

> How do I verify the case you tried so solve in bug 787172 still works?

It's somewhat tricky since the whole point of this code is to prevent races. Basically you need to provoke a system message from the RIL before Gaia has booted up and then ensure that Gaia still gets the system message.

A system messages that gets sent very early on is "icc-stkcommand" (bug 787175), provided your SIM card has an STK menu installed. There's no guarantee that the radio and SIM card come online before Gaia, but you could easily verify that with debug statements (turn DEBUG_ALL = true in ril_consts.js and add some console.log() statements to Gaia's system app).

Comment 2

[Andrew Overholt [:overholt]]

It seems like this was created with blocking-basecamp+ (by using clone bug on a blocker?) but we discussed it during triage and decided it wasn't actually a blocker.  Feel free to re-nom if you disagree.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

http://dxr.mozilla.org/mozilla-central/search?q=system-app-ready&case=true

Since removed -- not sure when it happened.