Closed
Bug 793438
Opened 12 years ago
Closed 12 years ago
Always add start menu shortcut on Win8 for metro browser builds
Categories
(Firefox for Metro Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 19
People
(Reporter: bbondy, Assigned: bbondy)
Details
(Whiteboard: metro-preview completed-elm)
Attachments
(1 file, 1 obsolete file)
|
3.31 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
The only way to access a Metro browser is through the start screen. We should therefore remove the option for an lnk on the start screen from the installer.
|
Assignee | |
Comment 1•12 years ago
|
||
If you prefer I can refactor the logic to have 2 ifdef moz_metro blocks (one around an atmostwin8, and the other around the endif).
Attachment #663743 -
Flags: review?(robert.bugzilla)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Easier to understand version of the last patch
Attachment #663743 -
Attachment is obsolete: true
Attachment #663743 -
Flags: review?(robert.bugzilla)
Attachment #663769 -
Flags: review?(robert.bugzilla)
|
|
Assignee | |
Comment 3•12 years ago
|
||
And in the last patch I would have had to put in the ifndef ${OrIf} true == true (yuck)|
|
Assignee | |
Comment 4•12 years ago
|
||
http://hg.mozilla.org/projects/elm/rev/1c77ec2645c4 Will sync review comments to elm
Whiteboard: metro-preview → metro-preview completed-elm
|
||
Updated•12 years ago
|
Component: Installer → General
Product: Firefox → Firefox for Metro
|
|
Assignee | |
Updated•12 years ago
|
Attachment #663769 -
Flags: review?(robert.bugzilla) → review?(jmathies)
|
|
||
Comment 5•12 years ago
|
||
Comment on attachment 663769 [details] [diff] [review] Patch v2 good to get rid of this.
Attachment #663769 -
Flags: review?(jmathies) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/d366c8f82a8b
Target Milestone: --- → Firefox 19
|
||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d366c8f82a8b
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•