793439 - crash in PL_DHashTableOperate

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase (uses specialpowers)

This bug was filed from the Socorro interface and is 
report bp-dbd2b88b-fc81-41cc-9bb3-ba2fb2120922 .
============================================================= 
0 	xul.dll 	PL_DHashTableOperate 	obj-firefox/xpcom/build/pldhash.cpp:576
1 	xul.dll 	nsCategoryManager::AddCategoryEntry 	xpcom/components/nsCategoryManager.cpp:581
2 	xul.dll 	nsCategoryManager::AddCategoryEntry 	xpcom/components/nsCategoryManager.cpp:562
3 	xul.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:70
4 	xul.dll 	XPCWrappedNative::CallMethod 	js/xpconnect/src/XPCWrappedNative.cpp:2405
5 	xul.dll 	XPC_WN_CallMethod 	js/xpconnect/src/XPCWrappedNativeJSOps.cpp:1469
6 	mozjs.dll 	js::InvokeKernel 	js/src/jsinterp.cpp:367
7 	mozjs.dll 	js::Invoke 	js/src/jsinterp.h:109
8 	mozjs.dll 	js_fun_apply 	js/src/jsfun.cpp:951
9 	mozjs.dll 	js::InvokeKernel 	js/src/jsinterp.cpp:367
10 	mozjs.dll 	js::Invoke 	js/src/jsinterp.h:109
etc...

Comment 1

[Josh Matthews [:jdm]]

I suspect the hashtable doesn't like null strings. Should be an easy fix - the only slightly complicated bit for somebody new would be importing the testcase into our test harness. It can probably a crashtest (https://developer.mozilla.org/en-US/docs/Running_automated_tests#Reftests), and it should live in xpcom/components/crashtests (which does not exist). Copy the relevant infrastructure from xpcom/strings (eg. stuff in Makefile.in, and crashtest/crashtest.list) to make it work. You'll need to build the xpcom/components directory, and you can run it with |TEST_PATH=xpcom/components/crashtests make -C [your_objdir_name] crashtest|.

Comment 2

[Benjamin Smedberg]

Can't we just mark this INVALID? You may not pass NULL to this function, it's a violation of the interface?

I'm not opposed to adding a null check, but I really don't think it was worth filing this.

Comment 3

[gmr]

Hi Josh,

I would like work on this. This will be first bug for me. This will help in understanding the process. Would need some right pointers. And also help regarding the addition of test case. Can this bug be assigned to me? Can I get some pointers towards working on the bug?

Comment 4

[Josh Matthews [:jdm]]

Actually, I think Benjamin's right. There's no particular reason to fix this, and the vast majority of the work would be getting to know our crazy test harness.

Comment 5

[Martijn Wargers (dead)]

SpecialPowers is not enabled yet for crashtests, see bug 792029.

You can test the testcase with the SpecialPowers extension: http://people.mozilla.org/~mwargers/extensions/specialpowers.xpi