Open
Bug 793441
Opened 12 years ago
Updated 2 years ago
Tautological constant out of range check on StyleRule.h
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
NEW
People
(Reporter: reuben, Unassigned)
Details
Attachments
(1 file)
|
5.31 KB,
patch
|
Details | Diff | Splinter Review |
This breaks the build on a recent Clang.
Attachment #663742 -
Flags: review?(dbaron)
|
Reporter | |
Comment 1•12 years ago
|
||
Hm, my editor is configured to trim trailing white space on save, so a bunch of that got into the patch. Is it OK to slip them in with this patch?
|
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 663742 [details] [diff] [review] Patch This patch is wrong, sorry for the bug spam. sizeof(enum) is implementation defined, and Clang emits the warning because it knows how many elements nsCSSPseudoElements::Type has. I don't think we're ever going to reach INT16_MAX pseudo elements, but if we want to keep the assertion, we'll need to add -Wno-tautological-out-of-range-comparison to CXXFLAGS in the near future.
Attachment #663742 -
Flags: review?(dbaron)
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•