793465 - Unconditional definition of HAVE_UINT64_T in configure.in

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

In configure.in it unconditionally defines HAVE_UINT64_T:

    # For now we assume that we will have a uint64_t available through
    # one of the above headers or mozstdint.h.
    AC_DEFINE(HAVE_UINT64_T)

This was added in bug 290518, with this comment from bryner:

   We need to define HAVE_UINT64_T, I guess. May as well do it unconditionally since we have this type available everywhere.

This is bad and messes up external code that assumes HAVE_UINT64_T doesn't lie.

Comment 1

[Nathan Froyd [:froydnj]]

Is this bug valid anymore now that we require stdint.h?

Comment 2

[sylvestre]

Attachment: fix-bug-793465.diff

Remove the unconditional declaration of HAVE_UINT64_T

External codes have their own definitions or management.

cairo:
Defined in gfx/cairo/cairo/src/cairo-wideint-type-private.h

intl:
Defined in intl/icu/source/configure.in

webrtc:
media/webrtc/signaling/signaling.gyp

netwerk:
netwerk/srtp/src/Makefile.in

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/91e1d8abb51e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out for Windows bustage.
https://hg.mozilla.org/integration/mozilla-inbound/rev/992194d6631f

https://tbpl.mozilla.org/php/getParsedLog.php?id=30710775&tree=Mozilla-Inbound

Comment 5

[sylvestre]

OK. I see two potential solutions here:
* Only enable the AC_DEFINE under Windows
* Hack cairo (cairo-wideint-type-private.h ?) to make sure that this defines is also available under Windows

Comment 6

[sylvestre]

Attachment: fix-bug-793465.diff

Here is the implementation of the first proposition (only enable the define under Windows).

Comment 7

[Peter Retzer (:pretzer)]

Comment on attachment 8335987 [details] [diff] [review]
fix-bug-793465.diff

In the future you should make sure to request review from an actual person, so it doesn't get lost. You can find suggested reviewers when you upload an attachment and click the 'suggested reviewers' link.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/518ace66cba3

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/518ace66cba3