Closed
Bug 793553
Opened 12 years ago
Closed 12 years ago
[b2g] oninput is not fired when the content of an input field is changed
Categories
(Firefox OS Graveyard :: General, defect)
Firefox OS Graveyard
General
Tracking
(blocking-basecamp:+)
People
(Reporter: vingtetun, Assigned: vingtetun)
Details
(Whiteboard: [WebAPI:P3])
Attachments
(1 file, 2 obsolete files)
1.08 KB,
patch
|
mounir
:
review+
|
Details | Diff | Splinter Review |
Discovered while working on the First-Run-Experience.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #663878 -
Flags: review?(fabrice)
Comment 2•12 years ago
|
||
Vivien, your patch isn't reproducing the behaviour of the input event. The event is fired whenever there is an input on the element, this includes input that do not produce any change. For example, if the value in "i", you select "i" and you press "i", an input event is fired.
Comment 3•12 years ago
|
||
Comment on attachment 663878 [details] [diff] [review] Patch Review of attachment 663878 [details] [diff] [review]: ----------------------------------------------------------------- I think you should always fire the input event, even if the value did not change.
Attachment #663878 -
Flags: review?(fabrice) → review-
Comment 4•12 years ago
|
||
We discussed this during triage today and it seems like a low-priority blocker.
blocking-basecamp: ? → +
Whiteboard: [WebAPI:P3]
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #663878 -
Attachment is obsolete: true
Attachment #664732 -
Flags: review?(mounir)
Assignee | ||
Comment 6•12 years ago
|
||
Sigh. Correct version of the patch.
Attachment #664732 -
Attachment is obsolete: true
Attachment #664732 -
Flags: review?(mounir)
Attachment #664740 -
Flags: review?(mounir)
Comment 7•12 years ago
|
||
Comment on attachment 664740 [details] [diff] [review] Patch Review of attachment 664740 [details] [diff] [review]: ----------------------------------------------------------------- ::: b2g/chrome/content/forms.js @@ +116,3 @@ > target.value = json.value; > + > + let event = content.document.createEvent('HTMLEvents'); I don't know why HTMLEvents is allowed but in C++ code, we always use Events. Anyway, both works and do the exact same thing.
Attachment #664740 -
Flags: review?(mounir) → review+
Assignee | ||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf4f7407c78d
Status: NEW → ASSIGNED
Target Milestone: --- → ProductDemo
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bf4f7407c78d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•