79362 - Missing symbols in libxpcom.so (IRIX/gcc)

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P2)

Description

[John Vandenberg]

Building mozilla with gcc on IRIX results in missing symbols 
nsXPTCStubBase::Stub130 in libxpcom.so

Looking in xpcom/reflect/xptcall/src/md/unix/, nm indicates that the symbols 
are missing because they should be nsXPTCStubBase::Stub130(void) 

And xpcom/reflect/xptcall/src/xptcall.o seems to be were the incorrectly named 
symbols come from.

---
% ./mozilla
...
12643702:./mozilla-bin: rld: Error: unresolvable symbol in ./libxpcom.so: 
Stub120__14nsXPTCStubBase
12643702:./mozilla-bin: rld: Error: unresolvable symbol in ./libxpcom.so: 
Stub20__14nsXPTCStubBase
...
---
% nm xpcom/reflect/xptcall/src/md/unix/libxptcmd.a | grep Stub130
[4]	|      4064|      32|FUNC |GLOB |DEFAULT  |4      
|Stub130__14nsXPTCStubBaseGv
---
% nm xpcom/build/libxpcom.so | grep Stub130
[509]	|1609924392|      32|FUNC |GLOB |DEFAULT  
|MIPS_TEXT|Stub130__14nsXPTCStubBaseGv
[902]	|         0|       0|FUNC |GLOB |DEFAULT  |UNDEF  
|Stub130__14nsXPTCStubBase
---
% nm xpcom/reflect/xptcall/src/xptcall.o | grep Stub130
[15]    |         0|       0|FUNC |GLOB |DEFAULT  |UNDEF  
|Stub130__14nsXPTCStubBase

Comment 1

[timeless]

I suppose this is really a build config issue, but dropping in XPCOM for the 
moment.

Comment 2

[John Vandenberg]

Attachment: Patch to xptcstubs_asm_irix.s for gcc only (will break MIPSpro build)

Comment 3

[John Vandenberg]

I have tested the above patch, and I now get a core dump after registration.

To enable both MIPSpro and GNU compilers to work, I presume there will need to 
be two irix .s files, and build changes will have to occur in these two.

xpcom/reflect/xptcall/src/md/unix/Makefile.in
xpcom/build/Makefile.in

Comment 4

[John Vandenberg]

I am unsure if the this problem is the cause, but mozilla (after registration)
and TextXPTCInvoke core dump.

% ./TestXPTCInvoke 
Warning: MOZILLA_FIVE_HOME not set.
calling direct:
        1 + 1 = 2
        1L + 1L = 2
        2 * 2 = 4
        2L * 2L = 4
        1 + 2 + 3 + 4 + 5 + 6 + 7 + 8 + 9 + 10 = 55.000000
        1 + 2 + 3 + 4 + 5 + 6 + 7 + 8 + 9 + 10 = 55.000000f
calling via invoke:
Segmentation fault (core dumped)

Comment 5

[John Vandenberg]

This takes me back to bug 43024 , and some diffs that did not make it into the 
tree, and some gcc specific asm code that got pulled out, and a minor 
rework ... and presto ... mozilla works!

Comment 6

[John Vandenberg]

Attachment: Patch to Makefile.in and irix.s (Tested on MIPSpro and GCC)

Comment 7

[John Vandenberg]

Attachment: Patch to xptcinvoke_asm_irix.s adding old GCC code

Comment 8

[Edward Kandrot]

I do not have the means of verifying this, and am unfamilar with SGI or IRIX.  I
am reassigning to the owner of the tracking bug, whom I assume will know who can
do this.  Thanks.

Comment 9

[cls]

r=cls

Comment 10

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to 0.9.1

Comment 11

[Richard Hess]

working on getting an ETA for this.  I'll update ASAP...

:-l

Comment 12

[cls]

Patch has been checked in.