Remove unnecessary prtypes.h includes from comm-central

RESOLVED FIXED in Thunderbird 18.0

Status

MailNews Core
Backend
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 18.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 663996 [details] [diff] [review]
The fix

We did this in core, soon after switching to uint32_t etc to attempt to minimise the places where developers might accidentally switch back to the old PR types.

This patch does the same for comm-central except we're also able to actually just remove all the cases where we have includes of prtypes.h.
Attachment #663996 - Flags: review?(Pidgeot18)

Updated

5 years ago
Status: NEW → ASSIGNED
Comment on attachment 663996 [details] [diff] [review]
The fix

Review of attachment 663996 [details] [diff] [review]:
-----------------------------------------------------------------

I would have expected that the CMS stuff in MIME would need PR* for interfacing with NSS, but on closer inspection, it uses the nsICMS* IDL definitions, which eliminates the need for PR* datatypes.

::: mailnews/addrbook/src/nsVCard.h
@@ +48,5 @@
>  #include "nsVCardObj.h"
>  
> +#ifdef __cplusplus
> +extern "C" {
> +#endif

I wonder if it's really necessary to make nsVCard.h and nsVCardObj.h be extern C? There's no C code remaining in our tree, and these aren't exported from libxul/libmail either. On the other hand, it's all probably going away before long anyways...
Attachment #663996 - Flags: review?(Pidgeot18) → review+
(Assignee)

Comment 2

5 years ago
Yeah, I wondered about dropping those, but thought that we might as well keep it as it is for now.

Checked in:
https://hg.mozilla.org/comm-central/rev/ea917ba8c785
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
You need to log in before you can comment on or make changes to this bug.