Last Comment Bug 793639 - Remove unnecessary prtypes.h includes from comm-central
: Remove unnecessary prtypes.h includes from comm-central
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Backend (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 18.0
Assigned To: Mark Banner (:standard8)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-24 03:28 PDT by Mark Banner (:standard8)
Modified: 2012-09-25 07:19 PDT (History)
1 user (show)
standard8: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
The fix (8.54 KB, patch)
2012-09-24 03:28 PDT, Mark Banner (:standard8)
Pidgeot18: review+
Details | Diff | Splinter Review

Description Mark Banner (:standard8) 2012-09-24 03:28:38 PDT
Created attachment 663996 [details] [diff] [review]
The fix

We did this in core, soon after switching to uint32_t etc to attempt to minimise the places where developers might accidentally switch back to the old PR types.

This patch does the same for comm-central except we're also able to actually just remove all the cases where we have includes of prtypes.h.
Comment 1 Joshua Cranmer [:jcranmer] 2012-09-24 08:52:02 PDT
Comment on attachment 663996 [details] [diff] [review]
The fix

Review of attachment 663996 [details] [diff] [review]:
-----------------------------------------------------------------

I would have expected that the CMS stuff in MIME would need PR* for interfacing with NSS, but on closer inspection, it uses the nsICMS* IDL definitions, which eliminates the need for PR* datatypes.

::: mailnews/addrbook/src/nsVCard.h
@@ +48,5 @@
>  #include "nsVCardObj.h"
>  
> +#ifdef __cplusplus
> +extern "C" {
> +#endif

I wonder if it's really necessary to make nsVCard.h and nsVCardObj.h be extern C? There's no C code remaining in our tree, and these aren't exported from libxul/libmail either. On the other hand, it's all probably going away before long anyways...
Comment 2 Mark Banner (:standard8) 2012-09-25 07:19:31 PDT
Yeah, I wondered about dropping those, but thought that we might as well keep it as it is for now.

Checked in:
https://hg.mozilla.org/comm-central/rev/ea917ba8c785

Note You need to log in before you can comment on or make changes to this bug.