Upgrade clang to r161152

RESOLVED FIXED in Thunderbird 18.0

Status

Thunderbird
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 18.0
x86_64
Linux
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 664002 [details] [diff] [review]
The fix

+++ This bug was initially created as a clone of Bug #787568 +++

We should upgrade to clang r161152 to match Firefox, additionally we should add in a check-sync-dirs check that our .manifest files match Firefox, and hence we'll automatically be notified if we miss a change that Firefox is doing (if we really desire to not be in sync for a period, then we can always turn it off or exclude files, but generally best to keep up to date).

I've tested the builds on try server:

Full build and test, but with broken check-sync-dirs test: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=3adc167fc287

Full build, following the fixing of the check sync-dirs test: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=db0aa75d073e
Attachment #664002 - Flags: review?(irving)
A better fix here would be to not have a separate clang manifest, it seems.
(Assignee)

Comment 2

5 years ago
If it is reasonable for m-c to not have separate clang manifests per an app, then I think that would be fine, but that doesn't seem to be the case at the moment and I don't know why they were done separate to being with.

I'd obviously do that as a follow-up bug, as at the moment I'd prefer to make sure we're on the same version.
(In reply to Ehsan Akhgari [:ehsan] from comment #1)
> A better fix here would be to not have a separate clang manifest, it seems.

The current limitation is that tooltool can be used for more than just clang, and I don't believe we can remote-include a manifest. The files-to-install per app via tooltool can also vary, and there are legit reasons for that.

So a check-sync-dirs change for TB to match Firefox [and SeaMonkey once we're finally buildable with clang] and actually matching is the best choice for now.
Attachment #664002 - Flags: review?(irving) → review+
(Assignee)

Comment 4

5 years ago
Checked in: https://hg.mozilla.org/comm-central/rev/2a961372e4da
Assignee: nobody → mbanner
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
(Assignee)

Comment 5

5 years ago
I had to do a follow-up to fix the checksums, as I'd got the wrong set:

https://hg.mozilla.org/comm-central/rev/e06d2b0f4a60
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.