Last Comment Bug 793643 - Upgrade clang to r161152
: Upgrade clang to r161152
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: Thunderbird 18.0
Assigned To: Mark Banner (:standard8)
:
:
Mentors:
Depends on: 787568
Blocks: 784691
  Show dependency treegraph
 
Reported: 2012-09-24 03:59 PDT by Mark Banner (:standard8)
Modified: 2012-09-26 03:41 PDT (History)
5 users (show)
standard8: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
The fix (5.02 KB, patch)
2012-09-24 03:59 PDT, Mark Banner (:standard8)
irving: review+
Details | Diff | Splinter Review

Description Mark Banner (:standard8) 2012-09-24 03:59:27 PDT
Created attachment 664002 [details] [diff] [review]
The fix

+++ This bug was initially created as a clone of Bug #787568 +++

We should upgrade to clang r161152 to match Firefox, additionally we should add in a check-sync-dirs check that our .manifest files match Firefox, and hence we'll automatically be notified if we miss a change that Firefox is doing (if we really desire to not be in sync for a period, then we can always turn it off or exclude files, but generally best to keep up to date).

I've tested the builds on try server:

Full build and test, but with broken check-sync-dirs test: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=3adc167fc287

Full build, following the fixing of the check sync-dirs test: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=db0aa75d073e
Comment 1 :Ehsan Akhgari 2012-09-24 11:58:25 PDT
A better fix here would be to not have a separate clang manifest, it seems.
Comment 2 Mark Banner (:standard8) 2012-09-24 12:29:59 PDT
If it is reasonable for m-c to not have separate clang manifests per an app, then I think that would be fine, but that doesn't seem to be the case at the moment and I don't know why they were done separate to being with.

I'd obviously do that as a follow-up bug, as at the moment I'd prefer to make sure we're on the same version.
Comment 3 Justin Wood (:Callek) 2012-09-24 14:29:02 PDT
(In reply to Ehsan Akhgari [:ehsan] from comment #1)
> A better fix here would be to not have a separate clang manifest, it seems.

The current limitation is that tooltool can be used for more than just clang, and I don't believe we can remote-include a manifest. The files-to-install per app via tooltool can also vary, and there are legit reasons for that.

So a check-sync-dirs change for TB to match Firefox [and SeaMonkey once we're finally buildable with clang] and actually matching is the best choice for now.
Comment 4 Mark Banner (:standard8) 2012-09-25 07:18:45 PDT
Checked in: https://hg.mozilla.org/comm-central/rev/2a961372e4da
Comment 5 Mark Banner (:standard8) 2012-09-26 03:41:33 PDT
I had to do a follow-up to fix the checksums, as I'd got the wrong set:

https://hg.mozilla.org/comm-central/rev/e06d2b0f4a60

Note You need to log in before you can comment on or make changes to this bug.