793719 - D2D error on metrofx shutdown

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jim Mathies [:jimm]]

For release builds, during shutdown, I always see:

DXGI WARNING: Process is terminating. Using simple reporting. Please call ReportLiveObjects() at runtime for standard reporting. [ STATE_CREATION WARNING #0: ]
DXGI WARNING: Live Producer at 0x00DE3728, Refcount: 5. [ STATE_CREATION WARNING #0: ]
DXGI WARNING: 	Live Object at 0x04797908, Refcount: 4. [ STATE_CREATION WARNING #0: ]
DXGI WARNING: 	Live Object at 0x0B24BE08, Refcount: 1. [ STATE_CREATION WARNING #0: ]
DXGI WARNING: Live                         Object :      2 [ STATE_CREATION WARNING #0: ]

In debug builds this generates an exception.

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1

Using dps from windbg I was able to track down the un-Released allocation to DrawTargetD2D::mFactory.

This was causing an error on shutdown for both desktop and metro runs of the browser.  I no longer get the error with this fix.

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 684822 [details] [diff] [review]
Patch v1

Review of attachment 684822 [details] [diff] [review]:
-----------------------------------------------------------------

I'm glad to see this exception go away. Although it's pretty easy to ignore :).

::: gfx/2d/Factory.cpp
@@ +444,5 @@
> +void
> +Factory::D2DCleanup()
> +{
> +  if (DrawTargetD2D::factory()) {
> +    DrawTargetD2D::factory()->Release();

I'd be a tiny bit happier if we actual made it nullptr here so that we don't risk a use-after-free.

Comment 3

[Brian R. Bondy [:bbondy]]

done
http://hg.mozilla.org/integration/mozilla-inbound/rev/c0c9d5933dcd

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c0c9d5933dcd