Closed Bug 793719 Opened 7 years ago Closed 7 years ago

D2D error on metrofx shutdown

Categories

(Core :: Graphics, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: jimm, Assigned: bbondy)

References

Details

(Whiteboard: [metro-it1][LOE:1][metro-mvp][completed-elm])

Attachments

(1 file)

For release builds, during shutdown, I always see:

DXGI WARNING: Process is terminating. Using simple reporting. Please call ReportLiveObjects() at runtime for standard reporting. [ STATE_CREATION WARNING #0: ]
DXGI WARNING: Live Producer at 0x00DE3728, Refcount: 5. [ STATE_CREATION WARNING #0: ]
DXGI WARNING: 	Live Object at 0x04797908, Refcount: 4. [ STATE_CREATION WARNING #0: ]
DXGI WARNING: 	Live Object at 0x0B24BE08, Refcount: 1. [ STATE_CREATION WARNING #0: ]
DXGI WARNING: Live                         Object :      2 [ STATE_CREATION WARNING #0: ]

In debug builds this generates an exception.
Blocks: 797201
Assignee: nobody → netzen
Whiteboard: [metro-it1][LOE:1][metro-mvp]
Attached patch Patch v1Splinter Review
Using dps from windbg I was able to track down the un-Released allocation to DrawTargetD2D::mFactory.

This was causing an error on shutdown for both desktop and metro runs of the browser.  I no longer get the error with this fix.
Attachment #684822 - Flags: review?(bas)
Comment on attachment 684822 [details] [diff] [review]
Patch v1

Review of attachment 684822 [details] [diff] [review]:
-----------------------------------------------------------------

I'm glad to see this exception go away. Although it's pretty easy to ignore :).

::: gfx/2d/Factory.cpp
@@ +444,5 @@
> +void
> +Factory::D2DCleanup()
> +{
> +  if (DrawTargetD2D::factory()) {
> +    DrawTargetD2D::factory()->Release();

I'd be a tiny bit happier if we actual made it nullptr here so that we don't risk a use-after-free.
Attachment #684822 - Flags: review?(bas) → review+
done
http://hg.mozilla.org/integration/mozilla-inbound/rev/c0c9d5933dcd
Target Milestone: --- → mozilla20
Whiteboard: [metro-it1][LOE:1][metro-mvp] → [metro-it1][LOE:1][metro-mvp][completed-elm]
https://hg.mozilla.org/mozilla-central/rev/c0c9d5933dcd
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.