Closed Bug 793773 Opened 14 years ago Closed 14 years ago

Some win32 l10n nightly builds fails with "!insertmacro: macro "__WinVer_DefineOSTest" requires 2 parameter(s), passed 3!"

Categories

(Release Engineering :: General, defect)

defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: unghost, Unassigned)

References

Details

Some win32 l10n nightly builds fails to build with "!insertmacro: macro "__WinVer_DefineOSTest" requires 2 parameter(s), passed 3!". See, for example http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n/1348506751.1348507047.22044.gz and http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n/1348506330.1348506602.21362.gz Sounds like caused by Bug 737833
Sounds like something is using NSIS 2.33, everything should be upgraded to NSIS 2.46.
Depends on: 776440
The patch for removing NSIS 2.33 is being tracked for beta and will possibly get approval for landing tonight.
Depends on: 791687
Severity: normal → blocker
Recommended action: Upgrade whatever is building with 2.33 to 2.46.
I don't think we should approve the nsis removal before we have this figured out.
We could try to rebase the patches that are needed to not include the nsis 2.33 removal, but I'd prefer to keep the bits the same to reduce risk of a regression on beta/aurora which is not on m-c. The last beta before the final is tomorrow, so we should try to fix this bug today.
The stub installer will also require 2.46 which will be landing soon by the way.
(In reply to Alexander L. Slovesnik from comment #0) > Some win32 l10n nightly builds fails to build with "!insertmacro: macro > "__WinVer_DefineOSTest" requires 2 parameter(s), passed 3!". See, for > example > http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n/1348506751. > 1348507047.22044.gz and > http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n/1348506330. > 1348506602.21362.gz > > Sounds like caused by Bug 737833 Both of these were built on mw32-ix-slave09, which is missing nsis-2.46. Since nsis-2.33 is still in PATH, it falls back to that.
Depends on: mw32-ix-slave09
Disabled mw32-ix-slave09 in slavealloc.
(In reply to Aki Sasaki [:aki] from comment #8) > Disabled mw32-ix-slave09 in slavealloc. Can we call this resolved now? Or are there more slaves to disable?
I think so.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.