Closed Bug 793800 Opened 12 years ago Closed 12 years ago

TBPL should recognise hg errors ("^abort: ")

Categories

(Tree Management Graveyard :: TBPL, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sheriff-want])

Attachments

(1 file)

Broken out from bug 793641.

Whilst hg failures are set to RETRY, it would still be nice if TBPL's annotated summary showed the reason for the retry, without having to open the log:

{
========= Started clone build tools failed (results: 5, elapsed: 1 secs) (at 2012-09-24 03:17:20.662054) =========
hg clone http://hg.mozilla.org/build/tools tools
 in dir /Users/cltbld/talos-slave/test/. (timeout 1320 secs)
 watching logfiles {}
 argv: ['hg', 'clone', 'http://hg.mozilla.org/build/tools', 'tools']
 environment:
  Apple_PubSub_Socket_Render=/tmp/launch-0HWyTr/Render
  CVS_RSH=ssh
  DISPLAY=/tmp/launch-OkShAP/org.x:0
  HOME=/Users/cltbld
  LOGNAME=cltbld
  PATH=/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11/bin
  PWD=/Users/cltbld/talos-slave/test
  PYTHONPATH=/Library/Python/2.5/site-packages
  SHELL=/bin/bash
  SSH_AUTH_SOCK=/tmp/launch-BiBKpA/Listeners
  TMPDIR=/var/folders/Hs/HsDn6a9SG8idoIya6p9mtE+++TI/-Tmp-/
  USER=cltbld
  VERSIONER_PYTHON_PREFER_32_BIT=no
  VERSIONER_PYTHON_VERSION=2.6
  __CF_USER_TEXT_ENCODING=0x1F5:0:0
 using PTY: False
abort: HTTP Error 500: Internal Server Error
program finished with exit code 255
elapsedTime=1.266496
========= Finished clone build tools failed (results: 5, elapsed: 1 secs) (at 2012-09-24 03:17:21.955880) =========
}
Attached patch Patch v1Splinter Review
Attachment #664153 - Flags: review?(arpad.borsos)
Attachment #664153 - Flags: review?(arpad.borsos) → review+
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/9282a188e3a3
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 794538
Yeah I'd seen those prior to landing. Whilst not the root cause of that failure case, I still think they add some clarity to the failure in the annotated summary (at least for people who know what it implies).

We can:
* Add regex to support "rm: cannot lstat `.*': Permission denied"

and then either:

a) accept that we'll have a double failure entry (the "rm:.*" and the "abort:.*") for this failure case
b) Make the clobber step fatal, so we don't blindly carry on 
c) Replace the generic "^abort:" with something more specific from http://hg.mozilla.org/build/buildbotcustom/file/802f2ec88379/status/errors.py#l12
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Depends on: 794760
Depends on: 794763
b') - haltOnFailure + RETRY to make the bad thing go away
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
No longer depends on: 794763
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: