Open Bug 793819 Opened 8 years ago Updated 7 years ago

sort out [default="true"] style in Thunderbird

Categories

(Thunderbird :: Theme, defect)

defect
Not set

Tracking

(Not tracked)

People

(Reporter: aceman, Assigned: aceman)

References

Details

(Keywords: polish, uiwanted)

(This was found in bug 679696.)

I tried to apply an attribute "default" set to "true" to pickup these rules from toolkit to style a menuitem as bold:
http://mxr.mozilla.org/comm-central/search?string=[default%3D%22true%22&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

It came out that that style is not defined for pinstripe (Mac). For the other themes, it is only defined for <button> and <menuitem>.

Here are some places that use the attribute:
http://mxr.mozilla.org/comm-central/search?string=.setAttribute%28%22default%22&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

From those e.g. the smtp dialog:
http://mxr.mozilla.org/comm-central/source/mailnews/base/prefs/content/am-smtp.js#199 isn't styled properly as there is no style for listitem[default="true"].

So the point of this bug is this:
1. decide whether the default items should be styled bold on Mac OS X, even though toolkit does not think so.
2. even for the other themes fix the existing usages of the attribute where it is set but the style is not found (define it in some proper .css) file. (e.g. am-stmp). This needs decision if there is some global .css file where to put this style (but messenger.css is not it, it isn't included everywhere) or just in the individual .css files where used (which would be faster at runtime). But this would mean a duplication of the definition...
3. convert hardcoded bold style to mark default items from classes to the default attribute to pick this style too. This could definitelly be used in the Manage Identities dialog and maybe in the Account manager too.
Maybe Seamonkey has this already sorted out?
Component: Account Manager → Theme
Product: MailNews Core → Thunderbird
1. No strong objections
2. We could either create a new global style possibly, or do it in messenger.css + also the additional places where it's needed. CCing Paenglab to see if he has any thoughts on that.
3. Sounds good.
1. I think it's okay to use the bold style. New messages are also bold and now the default server also. It also helps to point to something.
2. messenger.css is the most global for TB in comm-central. If it isn't used the should be put in the needed CSS file.
3. This makes sense.
Depends on: 736661
You need to log in before you can comment on or make changes to this bug.