793830 - Update Redirect For http://www.mozilla.org/contact/

Status: VERIFIED FIXED

(www.mozilla.org :: Legacy PHP system, defect)

Description

[Ben (:bensternthal)]

Please update the redirect for

http://www.mozilla.org/contact/

to

http://www.mozilla.org/en-US/about/contact.html

Comment 1

[Ben (:bensternthal)]

Attachment: Patch file

Comment 2

[Osmose [:osmose, :mkelly]]

Comment on attachment 666733 [details] [diff] [review]
Patch file

Review of attachment 666733 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good except my nits.

::: .htaccess
@@ +1536,4 @@
>  #
>  # These matched files have permanently moved and will return a 301 status.
>  #
> +RedirectMatch permanent ^/contact/ http://www.mozilla.org/about/contact.html

You should remove the "http://www.mozilla.org" from the redirect URL so that this will work across the dev and staging servers as well as production.

@@ +1536,5 @@
>  #
>  # These matched files have permanently moved and will return a 301 status.
>  #
> +RedirectMatch permanent ^/contact/ http://www.mozilla.org/about/contact.html
> +RedirectMatch permanent ^/developer/ https://developer.mozilla.org/docs/Developer_Guide

Aha, now I see why the other diff had this in it. Please remove. :)

Comment 3

[Ben (:bensternthal)]

Re-doing the patch.

1. Added the ?
2. Sep patch for /contact
3. Removed domain
3. As per discussion yesterday removing the dirs that are being completely redirected

Comment 4

[Ben (:bensternthal)]

Attachment: Added redirect, removed directory

Comment 5

[Osmose [:osmose, :mkelly]]

Comment on attachment 667075 [details] [diff] [review]
Added redirect, removed directory

Review of attachment 667075 [details] [diff] [review]:
-----------------------------------------------------------------

::: .htaccess
@@ +1536,4 @@
>  #
>  # These matched files have permanently moved and will return a 301 status.
>  #
> +RedirectMatch permanent ^/contact/? /about/contact.html

If you're removing the htaccess you should modify this regex to accept the old URLs as well (cool URLs don't change!).

Comment 6

[Ben (:bensternthal)]

The old htaccess had the following 3 entries:

-Redirect permanent /contact/moz-office-map.html http://www.mozilla.org/contact/
-Redirect permanent /contact/moz-office-map.gif http://www.mozilla.org/contact/
-Redirect permanent /contact/moz-office-map.png http://www.mozilla.org/contact/

So the blanket redirect covers these. I think based on that what I did was OK.

Comment 7

[Osmose [:osmose, :mkelly]]

Of course, these are partial matches. My mistake!