793886 - Say how long the log was before truncation

Status: RESOLVED DUPLICATE of bug 958327

(Release Engineering :: General, enhancement, P3)

Description

[Jesse Ruderman]

"Output exceeded 52428800 bytes, remaining output has been truncated"

Should say how long the original was, so we know how close we are to getting everything visible.

(e.g. https://tbpl.mozilla.org/php/getParsedLog.php?id=15458553&tree=Firefox )

Comment 1

[Chris AtLee [:catlee]]

shouldn't be too hard...the code for doing this is here: http://hg.mozilla.org/build/buildbot/file/128fd2247f85/master/buildbot/status/builder.py#l466

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: patch

I'm on a roll with issues related to Valgrind today.

This patch changes output to:

Output of x bytes exceeded y bytes, remaining output has been truncated

where x and y are numbers.

Comment 3

[Jesse Ruderman]

Comment on attachment 664309 [details] [diff] [review]
patch

To use a tuple on the RHS of %, you need to wrap it the tuple in parens.

Comment 4

[Chris AtLee [:catlee]]

Comment on attachment 664309 [details] [diff] [review]
patch

Review of attachment 664309 [details] [diff] [review]:
-----------------------------------------------------------------

that doesn't interpolate the way you want it to. also, that message is generated as soon as the log limit is exceeded, and we don't know how large the log is yet.

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: patch v2, not working

This merely provides more information about the amount of excess bytes it went over, it doesn't yet address the issue catlee pointed out, who suggests that we might have to wait till the end, in finish().

Comment 6

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Unfortunately I have to punt on this.