Closed Bug 793959 Opened 8 years ago Closed 8 years ago

MediaConduit - Roll Up Comments

Categories

(Core :: WebRTC: Signaling, defect)

Product:
Core
Component:
WebRTC: Signaling
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla18

People

(Reporter: snandaku, Assigned: snandaku)

References

Details

(Whiteboard: [WebRTC][blocking-webrtc+][fixed by bug 792188][qa-])

Attachments

(1 file, 2 obsolete files)

Incorported Latest Comments
43.30 KB, patch
Details | Diff | Splinter Review 
No description provided.
Assignee: nobody → snandaku
Attached patch Incorported Latest Comments (obsolete) — — Splinter Review
Summary: MediaConduit - Fix Comments → MediaConduit - Roll Up Comments
Attached patch Incorported Latest Comments (obsolete) — — Splinter Review
Attachment #664358 - Attachment is obsolete: true
Attachment #664363 - Attachment is obsolete: true
Attachment #664364 - Flags: review?(ethanhugg)
Attachment #664364 - Flags: review?(ekr)
Comment on attachment 664364 [details] [diff] [review]
Incorported Latest Comments

Review of attachment 664364 [details] [diff] [review]:
-----------------------------------------------------------------

What am I looking at here? Please upload the complete patchset, not just your diffs.

You can either do it here or on rietveld (upload.py works better than doing it by hand).
(In reply to Eric Rescorla from comment #4)
> Comment on attachment 664364 [details] [diff] [review]
> Incorported Latest Comments
> 
> Review of attachment 664364 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> What am I looking at here? Please upload the complete patchset, not just
> your diffs.
> 
> You can either do it here or on rietveld (upload.py works better than doing
> it by hand).

I think i am missing something here .. i did the normal hg bzexport as i usually do with any bugs .. is there a different want to do it ?
You need to do a diff against a revision from before these files existed. I'm re-reviewing the whole file, not just these diffs.
Whiteboard: [WebRTC], [blocking-webrtc+]
Comment on attachment 664364 [details] [diff] [review]
Incorported Latest Comments


Rolled up by Jesup in uplift to M-C.
Attachment #664364 - Flags: review?(ethanhugg)
Attachment #664364 - Flags: review?(ekr)
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Do we have a landing changeset here?
Target Milestone: --- → mozilla18
Perhaps this should be listed as a dupe of 792188.  These changes are on that bug as patch 5 and were rolled up with the other patches by Jesup.  M-C patch - https://hg.mozilla.org/mozilla-central/rev/4bea9e9d2e2c
Lets just reference it. Thanks Ethan!
Depends on: 792188
Whiteboard: [WebRTC], [blocking-webrtc+] → [WebRTC][blocking-webrtc+][fixed by bug 792188]
Whiteboard: [WebRTC][blocking-webrtc+][fixed by bug 792188] → [WebRTC][blocking-webrtc+][fixed by bug 792188][qa-]
You need to log in before you can comment on or make changes to this bug.