Closed
Bug 793959
Opened 13 years ago
Closed 13 years ago
MediaConduit - Roll Up Comments
Categories
(Core :: WebRTC: Signaling, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: snandaku, Assigned: snandaku)
References
Details
(Whiteboard: [WebRTC][blocking-webrtc+][fixed by bug 792188][qa-])
Attachments
(1 file, 2 obsolete files)
|
43.30 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Summary: MediaConduit - Fix Comments → MediaConduit - Roll Up Comments
Attachment #664358 -
Attachment is obsolete: true
Attachment #664363 -
Attachment is obsolete: true
Attachment #664364 -
Flags: review?(ethanhugg)
Attachment #664364 -
Flags: review?(ekr)
|
||
Comment 4•13 years ago
|
||
Comment on attachment 664364 [details] [diff] [review]
Incorported Latest Comments
Review of attachment 664364 [details] [diff] [review]:
-----------------------------------------------------------------
What am I looking at here? Please upload the complete patchset, not just your diffs.
You can either do it here or on rietveld (upload.py works better than doing it by hand).
(In reply to Eric Rescorla from comment #4)
> Comment on attachment 664364 [details] [diff] [review]
> Incorported Latest Comments
>
> Review of attachment 664364 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> What am I looking at here? Please upload the complete patchset, not just
> your diffs.
>
> You can either do it here or on rietveld (upload.py works better than doing
> it by hand).
I think i am missing something here .. i did the normal hg bzexport as i usually do with any bugs .. is there a different want to do it ?
|
|
||
Comment 6•13 years ago
|
||
You need to do a diff against a revision from before these files existed. I'm re-reviewing the whole file, not just these diffs.
|
||
Updated•13 years ago
|
Whiteboard: [WebRTC], [blocking-webrtc+]
|
||
Comment 7•13 years ago
|
||
Comment on attachment 664364 [details] [diff] [review]
Incorported Latest Comments
Rolled up by Jesup in uplift to M-C.
Attachment #664364 -
Flags: review?(ethanhugg)
Attachment #664364 -
Flags: review?(ekr)
|
|
||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 8•13 years ago
|
||
Do we have a landing changeset here?
|
|
||
Updated•13 years ago
|
Target Milestone: --- → mozilla18
|
|
||
Comment 9•13 years ago
|
||
Perhaps this should be listed as a dupe of 792188. These changes are on that bug as patch 5 and were rolled up with the other patches by Jesup. M-C patch - https://hg.mozilla.org/mozilla-central/rev/4bea9e9d2e2c
|
|
||
Comment 10•13 years ago
|
||
Lets just reference it. Thanks Ethan!
Depends on: 792188
Whiteboard: [WebRTC], [blocking-webrtc+] → [WebRTC][blocking-webrtc+][fixed by bug 792188]
|
|
||
Updated•13 years ago
|
Whiteboard: [WebRTC][blocking-webrtc+][fixed by bug 792188] → [WebRTC][blocking-webrtc+][fixed by bug 792188][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•