794024 - L10n fa: Translate bookmark aboutHome string

Status: RESOLVED FIXED

(Mozilla Localizations :: fa / Persian, defect)

Description

[Sina Momken]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20100101 Firefox/14.0.1
Build ID: 20120713134347

Steps to reproduce:

I tried to add "fa" locale to my build of fennec, but I couldn't. I could add all other locales in http://hg.mozilla.org/l10n-central/ except fa and he.
However I could track the logs and find the problem, and I could correct it.


Actual results:

I was localizing my build of fennec using steps in http://escapewindow.dreamwidth.org/234671.html
However at step "add the locales to your objdir, " (using command mozharness/scripts/multil10n.py --cfg myconfig.py --add-locales) I found a bug in fa localization.


Expected results:

The main problem is in definition of "bookmarks_aboutHome" which was undefined.
I add the line 
#define bookmarks_aboutHome فایرفاکس شروع
with the translation of "Firefox Start" to Farsi in front of it and after that the problem solved.

Comment 1

[Sina Momken]

Hello moderator
I want to commit the corrected file under my name as the copyright holder of this bug.
Actually I want to contribute in mozilla project. So I need commit access to that file.

Comment 2

[Sina Momken]

Attachment: Author's SSH public key to access commit to correct the bug

This is author's SSH public key yo access commit to correct the bug.
As the author my name is Sina Momken and I want to use [e-mail] as the email I want to use to login

Comment 3

[Sina Momken]

I've sent in the Agreement(http://www.mozilla.org/hacking/notification/)

Comment 4

[Sina Momken]

Attachment: My offered patch to fix this bug.

My offered patch to fix this bug, according to the previous comments.

Comment 5

[Sina Momken]

Dear moderators
After discussing at #introduction IRC channel I found out that I requested commit access on a wrong place. Plus I don't want to have commit access now and if you can fix it using my patch it's also enough for me.
It seems that there're more serious problems like RTL support for fennec that I should work on.

Comment 6

[Ekanan Ketunuti]

> I found out that I requested commit access on a wrong place. Plus I don't want to have commit access now...

ok, back to l10n

Comment 7

[(no longer active)]

I will be happy to land the patch for you if you provide a patch here.

Comment 8

[Sina Momken]

I don't know whether you can see my patch or not but actually I've attached a patch here.
However I'll change the patch reviewer from mozillamarcia.knous to you :D

Comment 9

[(no longer active)]

Comment on attachment 664847 [details] [diff] [review]
My offered patch to fix this bug.

Oh, sorry, I somehow missed this patch!

Can you please change this to فایرفاکس: شروع?  I find that translation a bit clearer.  Once you've done that, please attach a patch and I'll check it in for you.

Comment 10

[(no longer active)]

Hmm, speaking of which, Pike, where should l10n patches go these days? l10n-central or aurora or beta, or all of them?

Comment 11

[Axel Hecht [:Pike]]

You'd want to land on aurora, and possibly merge back to central, but that's optional.

From aurora, I migrate to beta, all it needs to make it into release is an actual sign-off on the change, too.

Comment 12

[Sina Momken]

(In reply to Ehsan Akhgari [:ehsan] from comment #9)
> Comment on attachment 664847 [details] [diff] [review]
> My offered patch to fix this bug.
> 
> Oh, sorry, I somehow missed this patch!
> 
> Can you please change this to فایرفاکس: شروع?  I find that translation a bit
> clearer.  Once you've done that, please attach a patch and I'll check it in
> for you.

But Ehsan: I wanted to translate to that, but if you see the original English file you'll see that it doesn't have any ":" in that, just "#define bookmarks_aboutHome Firefox Start".
All other translations don't have any ":" too.
That was why I omitted : in my translation patch.

Comment 13

[(no longer active)]

(In reply to comment #12)
> (In reply to Ehsan Akhgari [:ehsan] from comment #9)
> > Comment on attachment 664847 [details] [diff] [review]
> > My offered patch to fix this bug.
> > 
> > Oh, sorry, I somehow missed this patch!
> > 
> > Can you please change this to ÙاÛرÙاکس: شرÙع?  I find that translation a bit
> > clearer.  Once you've done that, please attach a patch and I'll check it in
> > for you.
> 
> But Ehsan: I wanted to translate to that, but if you see the original English
> file you'll see that it doesn't have any ":" in that, just "#define
> bookmarks_aboutHome Firefox Start".
> All other translations don't have any ":" too.
> That was why I omitted : in my translation patch.

That's true, but the existing translation doesn't really make sense in Persian.  Can you think of a better translation?

Comment 14

[Sina Momken]

I've checked the original En file again. I agree with you however I think the original phrase "
Firefox Start" doesn't make sense too. I guess the original author forgot to place ":" between them.
Anyway it seems that you've plused my patch review. Did you accepted the patch or I should make another patch containing ":"?

Comment 15

[(no longer active)]

(In reply to comment #14)
> I've checked the original En file again. I agree with you however I think the
> original phrase "
> Firefox Start" doesn't make sense too. I guess the original author forgot to
> place ":" between them.
> Anyway it seems that you've plused my patch review. Did you accepted the patch
> or I should make another patch containing ":"?

Please make another one with the colon.  And thanks so much! :-)

Comment 16

[Sina Momken]

Attachment: My offered patch to fix this bug (with colon)

The patch to fix the undefined variable, now also with : in translation to Fa.

Comment 17

[(no longer active)]

Comment on attachment 665826 [details] [diff] [review]
My offered patch to fix this bug (with colon)

Thanks!

Comment 18

[(no longer active)]

http://hg.mozilla.org/releases/l10n/mozilla-aurora/fa/rev/4efddcc5c86b