hal::AdjustSystemClock should take a 64-bit value

RESOLVED FIXED in mozilla18

Status

()

Core
Hardware Abstraction Layer (HAL)
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Justin Lebar (not reading bugmail), Assigned: Gene Lian (I already quit Mozilla))

Tracking

(Blocks: 1 bug)

Trunk
mozilla18
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(blocking-basecamp:+)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Right now, hal::AdjustSystemClock takes a signed 32-bit delta, representing the number of ms we want to move the clock forward or backwards.

That means we can't adjust the system clock more than 2^31 / (24 * 60 * 60 * 1000) = 25 days!!

We need to change this to a 64-bit value.  I'd also be OK if we changed it to take an absolute date, instead of an interval.  That might be slightly less accurate, but I'm not sure it matters.
(Reporter)

Updated

5 years ago
Blocks: 714349
(Reporter)

Comment 1

5 years ago
I think this bug will make us incapable of properly setting the system clock when we receive the time from a cell tower, if the system time is more than 25 days off from the cell tower.  Ouch.
blocking-basecamp: --- → ?
(Reporter)

Comment 2

5 years ago
Gene, do you want to take this one?
blocking-basecamp: ? → +
(Assignee)

Comment 3

5 years ago
Make sense to me! Should be able to come back with the patch very soon.
Assignee: nobody → clian
(Assignee)

Updated

5 years ago
Blocks: 789973
(Assignee)

Comment 4

5 years ago
Created attachment 664780 [details] [diff] [review]
Patch

Changes are trivial. s/int32_t/int64_t. Please let me know if any details can be improved. Thanks!
Attachment #664780 - Flags: review?(jones.chris.g)
Attachment #664780 - Flags: review?(jones.chris.g) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b444917f491
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6b444917f491
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.