Last Comment Bug 794186 - remove remaining PRInt32/PRUint32 usages in comm-central
: remove remaining PRInt32/PRUint32 usages in comm-central
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Backend (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Thunderbird 18.0
Assigned To: :aceman
:
Mentors:
Depends on: stdint
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-25 11:36 PDT by :aceman
Modified: 2012-09-27 13:46 PDT (History)
2 users (show)
standard8: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (5.23 KB, patch)
2012-09-25 12:12 PDT, :aceman
standard8: review+
Details | Diff | Splinter Review

Description :aceman 2012-09-25 11:36:44 PDT
The preferred way is to use int32_t and uint32_t instead. There are some PR*int32 being introduced in new patches, after bug 579517 converted them all globally.

/mailnews/base/src/nsMsgAccount.cpp (View Hg log or Hg annotations)

    line 263 -- PRInt32 position = m_identities->IndexOf(aDefaultIdentity);

/mailnews/base/src/nsMsgAccountManager.cpp (View Hg log or Hg annotations)

    line 393 -- for (PRInt32 lastKey = 1; ; lastKey++)
    line 410 -- PRInt32 i = 1;
    line 1480 -- PRInt32 secondsToLeave = 0;
    line 1481 -- PRInt32 timeUnavailable = 0;
    line 1517 -- if ((PRInt32)nowSeconds < timeUnavailable + secondsToLeave)

/mailnews/news/src/nsNewsFolder.cpp (View Hg log or Hg annotations)

    line 814 -- //PRint32 deltaInDB = m_totalInDB - m_unreadInDB;

/mailnews/base/src/nsMsgAccountManager.cpp (View Hg log or Hg annotations)

    line 1505 -- PRUint32 nowSeconds;
    line 1515 -- PRUint32 nowSeconds;
Comment 1 :aceman 2012-09-25 12:12:02 PDT
Created attachment 664610 [details] [diff] [review]
patch
Comment 2 Mark Banner (:standard8) (afk until 26th July) 2012-09-27 13:46:37 PDT
Checked in:

https://hg.mozilla.org/comm-central/rev/b25b81b354c2

Note You need to log in before you can comment on or make changes to this bug.