Closed Bug 794186 Opened 8 years ago Closed 8 years ago

remove remaining PRInt32/PRUint32 usages in comm-central

Categories

(MailNews Core :: Backend, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 18.0

People

(Reporter: aceman, Assigned: aceman)

References

Details

Attachments

(1 file)

The preferred way is to use int32_t and uint32_t instead. There are some PR*int32 being introduced in new patches, after bug 579517 converted them all globally.

/mailnews/base/src/nsMsgAccount.cpp (View Hg log or Hg annotations)

    line 263 -- PRInt32 position = m_identities->IndexOf(aDefaultIdentity);

/mailnews/base/src/nsMsgAccountManager.cpp (View Hg log or Hg annotations)

    line 393 -- for (PRInt32 lastKey = 1; ; lastKey++)
    line 410 -- PRInt32 i = 1;
    line 1480 -- PRInt32 secondsToLeave = 0;
    line 1481 -- PRInt32 timeUnavailable = 0;
    line 1517 -- if ((PRInt32)nowSeconds < timeUnavailable + secondsToLeave)

/mailnews/news/src/nsNewsFolder.cpp (View Hg log or Hg annotations)

    line 814 -- //PRint32 deltaInDB = m_totalInDB - m_unreadInDB;

/mailnews/base/src/nsMsgAccountManager.cpp (View Hg log or Hg annotations)

    line 1505 -- PRUint32 nowSeconds;
    line 1515 -- PRUint32 nowSeconds;
Attached patch patchSplinter Review
Attachment #664610 - Flags: review?(mbanner)
Status: NEW → ASSIGNED
Attachment #664610 - Flags: review?(mbanner) → review+
Keywords: checkin-needed
Checked in:

https://hg.mozilla.org/comm-central/rev/b25b81b354c2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
You need to log in before you can comment on or make changes to this bug.