The default bug view has changed. See this FAQ.

remove remaining PRInt32/PRUint32 usages in comm-central

RESOLVED FIXED in Thunderbird 18.0

Status

MailNews Core
Backend
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 18.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The preferred way is to use int32_t and uint32_t instead. There are some PR*int32 being introduced in new patches, after bug 579517 converted them all globally.

/mailnews/base/src/nsMsgAccount.cpp (View Hg log or Hg annotations)

    line 263 -- PRInt32 position = m_identities->IndexOf(aDefaultIdentity);

/mailnews/base/src/nsMsgAccountManager.cpp (View Hg log or Hg annotations)

    line 393 -- for (PRInt32 lastKey = 1; ; lastKey++)
    line 410 -- PRInt32 i = 1;
    line 1480 -- PRInt32 secondsToLeave = 0;
    line 1481 -- PRInt32 timeUnavailable = 0;
    line 1517 -- if ((PRInt32)nowSeconds < timeUnavailable + secondsToLeave)

/mailnews/news/src/nsNewsFolder.cpp (View Hg log or Hg annotations)

    line 814 -- //PRint32 deltaInDB = m_totalInDB - m_unreadInDB;

/mailnews/base/src/nsMsgAccountManager.cpp (View Hg log or Hg annotations)

    line 1505 -- PRUint32 nowSeconds;
    line 1515 -- PRUint32 nowSeconds;
(Assignee)

Comment 1

5 years ago
Created attachment 664610 [details] [diff] [review]
patch
Attachment #664610 - Flags: review?(mbanner)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Attachment #664610 - Flags: review?(mbanner) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Checked in:

https://hg.mozilla.org/comm-central/rev/b25b81b354c2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
You need to log in before you can comment on or make changes to this bug.