794236 - Firefox for Android is not localized above articles

Status: RESOLVED FIXED

(support.mozilla.org :: Localization, task)

Description

[Scoobidiver (away)]

It's Firefox for mobile in the header of each mobile article.
See https://support.mozilla.org/fr/kb/est-ce-que-firefox-fonctionnera-sur-appareil-mobile or https://support.mozilla.org/de/kb/funktioniert-firefox-mit-meinem-mobilgeraet
It works in topics pages. See https://support.mozilla.org/fr/products/mobile/download-and-install

Maybe related to bug 791251 (is it a logo?)

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

Possibly a missing or incorrect gettext call?

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

We need to change `{{ product.title }}` with `{{ _(product.title, 'DB: products.Product.title') }}.

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

It is now Firefox for Android.

Comment 4

[Michał Frontczak [:fxa90id] ♥]

I looked in https://github.com/mozilla/kitsune/blob/master/apps/products/templates/products/product.html but {{ product.title }} is already changed to {{ _(product.title, 'DB: products.Product.title') }} or I looked in bad file?

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Michał Frontczak :fxa90id from comment #4)
> I looked in
> https://github.com/mozilla/kitsune/blob/master/apps/products/templates/
> products/product.html but {{ product.title }} is already changed to {{
> _(product.title, 'DB: products.Product.title') }} or I looked in bad file?

This bug refers to the article page, so it's this template here:
https://github.com/mozilla/kitsune/blob/master/apps/wiki/templates/wiki/document.html#L30

Comment 6

[Michał Frontczak [:fxa90id] ♥]

https://github.com/mozilla/kitsune/pull/1176

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/3faa81562f79529dba7b6bfb4b0f30f83298de98

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod now. Thanks Michał!