(Full) b2g builds broken by bug 791775

RESOLVED FIXED

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: cjones, Assigned: cjones)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

build/core/base_rules.mk:82: *** Module name: test_google_breakpad
build/core/base_rules.mk:83: *** Makefile location: gecko/toolkit/crashreporter/google-breakpad/android/sample_app/jni
build/core/base_rules.mk:84: * 
build/core/base_rules.mk:85: * Each module must use a LOCAL_MODULE_TAGS in its
build/core/base_rules.mk:86: * Android.mk. Possible tags declared by a module:

The breakpad update pulled in some Android.mk turds we don't want.  Need to block them.
Created attachment 664707 [details] [diff] [review]
Block the android build system from looking in mozilla-central
Assignee: nobody → jones.chris.g
Attachment #664707 - Flags: review?(mwu)

Updated

6 years ago
Attachment #664707 - Flags: review?(mwu) → review+
https://hg.mozilla.org/mozilla-central/rev/acd23e460291

Need to get this merged to inbound asap.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
catlee landed a separate fix for this in bug 777530, just hg rm'ing the Android.mk files in question.
That can make updating more annoying, and doesn't fix the next case when a subproject we import adds more Android.mk turds.
For next time we could either throw an empty Android.mk in the m-c root, or relocate gecko/ in the B2G tree under gonk-misc/ or somewhere else that already has a Android.mk that does not recurse.  The former is surely less painful for B2G folks.
oh nm.  that's exactly what you did :)
You need to log in before you can comment on or make changes to this bug.