Closed
Bug 794320
Opened 12 years ago
Closed 11 years ago
Deprecate tab.favicon on fennec
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evold, Assigned: jsantell)
References
Details
(Whiteboard: [good first bug])
Attachments
(1 file)
This is async on Fennec..
Priority: -- → P1
|
Reporter | |
Comment 1•11 years ago
|
||
May I rename this bug to 'Deprecate tab.favicon' and make the work two parts: 1. add a deprecation warning when using tab.favicon 2. add a separate method someplace that will get a favicon for a given tab and return a promise.
Flags: needinfo?(rFobic)
|
|
Reporter | |
Updated•11 years ago
|
Whiteboard: [good first bug]
|
||
Comment 2•11 years ago
|
||
Erik `.favicon` is also broken on desktop, and I proposed to do exactly what you suggested (with minor diff that it should also accept callback). See Bug 834942 for details.
Flags: needinfo?(rFobic)
|
|
Reporter | |
Updated•11 years ago
|
Summary: Implement tab.favicon for Fennec → Deprecate tab.favicon
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → jsantell
|
|
Assignee | |
Updated•11 years ago
|
Summary: Deprecate tab.favicon → Deprecate tab.favicon on fennec
|
|
Assignee | |
Comment 3•11 years ago
|
||
With getFavicon method (which will be tested to see if it works on Fennec appropriately with tabs), this should just display a deprecated message to use `getMethod` instead of the getter
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #768671 -
Flags: review?(evold)
|
|
Reporter | |
Comment 5•11 years ago
|
||
Comment on attachment 768671 [details]
GH Pull Request 1065
Looks good! needs a test.
Attachment #768671 -
Flags: review?(evold) → review-
|
||
Comment 6•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/0c4b314aea147f6652c1d2cfab8ca522962c9560 Bug 794320 Clarify deprecation message in tab.favicon for Fennec https://github.com/mozilla/addon-sdk/commit/e4774f582163f5252cc5788be08987ae9e7e1453 Merge pull request #1065 from jsantell/favicon-dep Bug 794320 Clarify deprecation message in tab.favicon for Fennec, r=@erikvold
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•