794386 - do not store blob: URIs in global history

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Frederik Braun [:freddy]]

blob URIs are very volatile and supposed to be
a) bound to an origin, i.e. only accessible for the origin they were created in.
b) revoked after the document has been unloaded.

I can open blob URIs in other tabs, which creates a history entry. What use is it, to have this history entry?

My suggestion: don't store them in the first place (or remove them on revocation)


I guess this depends on bug 773132, implementing automatic revocation.

Comment 1

[Masatoshi Kimura [:emk]]

Bug 773132 is not related at all.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Are you talking about global history here, or session history?

Comment 3

[Frederik Braun [:freddy]]

Sorry, I'm not sure about the distinction between global and session history. I'll try to clarify my bug description.

Steps to reproduce:
1) b = new Blob(['foo']); u = window.URL.createObjectURL(b);
2) Then I open the blob URL in a new window (be it with window.open or manually)
3) Restart Firefox
4) Notice that the tabs with the blob URL contain blank pages (blob URIs invalidated?)
5) Close the tabs
6) Open the history (e.g. CTRL+H)
7) Search for "blob:"
8) blob URIs are in the history, but point to something that the browser *knows* is not valid anymore


I hope this doesn't add any confusion.

Comment 4

[Boris Zbarsky [:bzbarsky]]

That's global history.  

Gavin, do you recall whether docshell is supposed to filter URLs for that, or does Places do it?

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Places does most of the filtering, see nsNavHistory::CanAddURI. I think you should just add blob: to its scheme blacklist.

Comment 6

[Andrea Marchesini [:baku]]

Attachment: patch 1

Is this enough?

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 669105 [details] [diff] [review]
patch 1

Yes, thanks.

Comment 8

[Andrea Marchesini [:baku]]

Attachment: patch 1

added r=gavin.sharp

Comment 9

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8db471894559

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We're going to need to add 'mediastream' and 'mediasource' to this list. Should we make it a whitelist instead of a blacklist?

Comment 11

[Marco Bonardo [:mak]]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #10)
> Should we make it a whitelist instead of a blacklist?

Yes, I suggested this long time ago, I also think would be better.

Comment 12

[Frederik Braun [:freddy]]

FWIW, I agree :)

Comment 13

[Andrea Marchesini [:baku]]

I agree too, file a bug.

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8db471894559