794410 - Drag and dropping an about: tab (e.g. about:newtab, about:config, etc.) to the download button downloads the associated XUL file

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[PikeUK]

Drag and dropping an about: tab (e.g. about:newtab, about:config, etc.) to the download button downloads the associated XUL file.

Steps to reproduce:
1. Open a new blank tab.
2. Drag the new tab and drop on the downloads button.

A XUL file is downloaded to the Downloads directory.

Comment 1

[Antoine Turmel [:GeekShadow]]

It

Comment 2

[Marco Bonardo [:mak] (Away July 4-13)]

This doesn't happen dragging to the old manager, and doesn't sound like a particularly useful feature to keep.

Comment 3

[:Cykesiopka]

Attachment: Proposed Patch

Pasting an about: tab into the downloads popup also seems to suffer the same problem... But maybe for another bug?

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 734204 [details] [diff] [review]
Proposed Patch

>@@ -533,16 +533,20 @@ const DownloadsIndicatorView = {
>     // If dragged item is from our source, do not try to
>     // redownload already downloaded file.
>     if (dt.mozGetDataAt("application/x-moz-file", 0))
>       return;
> 
>     let name = {};
>     let url = browserDragAndDrop.drop(aEvent, name);
>     if (url) {
>+      if (url.indexOf("about:") == 0) {
>+          return;
>+      }

Indentation is off.
You can use url.startsWith(...) instead of url.indexOf(...) == 0.

Comment 5

[:Cykesiopka]

(In reply to Dão Gottwald [:dao] from comment #4)
> Comment on attachment 734204 [details] [diff] [review]
> Proposed Patch
> 
> >@@ -533,16 +533,20 @@ const DownloadsIndicatorView = {
> >     // If dragged item is from our source, do not try to
> >     // redownload already downloaded file.
> >     if (dt.mozGetDataAt("application/x-moz-file", 0))
> >       return;
> > 
> >     let name = {};
> >     let url = browserDragAndDrop.drop(aEvent, name);
> >     if (url) {
> >+      if (url.indexOf("about:") == 0) {
> >+          return;
> >+      }
> 
> Indentation is off.
> You can use url.startsWith(...) instead of url.indexOf(...) == 0.

Ah, thanks!

Comment 6

[:Cykesiopka]

Attachment: Proposed Patch v2

Fixes indentation and uses startsWith()

Comment 7

[:Paolo Amadini]

Comment on attachment 734298 [details] [diff] [review]
Proposed Patch v2

Review of attachment 734298 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch!

Comment 8

[:Cykesiopka]

(In reply to Paolo Amadini [:paolo] from comment #7)
> Thanks for the patch!

No problem!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c2ce06b2fa04

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c2ce06b2fa04

Comment 11

[Mitza]

Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:23.0) Gecko/20130421 Firefox/23.0

Verified as fixed on Firefox latest nightly (Build ID:	20130421031002).

Comment 12

[Maria Grazia Alastra [:mga]]

Verified as fixed also on latest Nightly 24.0, on Windows 7, 64 bits.

- User agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:24.0) Gecko/20130519 Firefox/24.0, Build ID: 20130519031035