794459 - "Profile updated" message displayed twice

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[Victor Carciu]

Attachment: Screenshot

Prerequisites:
Android 4.0.4, Firefox Nightly installed

Steps to reproduce:
1.Go to https://marketplace-dev.allizom.org/ and press "Settings" button
2.Modify something to your profile(eg. Display name)
3.Press "Save changes" button twice

Expected results:
"Profile updated " message is displayed only one time.

Actual results:
"Profile updated" message is displayed twice

Please see attached screenshot for this bug.

NOTE:
Reproducible also on desktop , responsive design view(320x480)

Comment 1

[Christopher Van Wiemeersch [:cvan]]

This happens for a lot of forms. We ought to just prevent double clicks on submit buttons.

Comment 2

[Wil Clouser [:clouserw]]

This seems to contradict bug 798357, but assigning to basta since he's got the other bug.  Preventing double clicks wfm.

Comment 3

[Matt Basta [:basta]]

My fix is pretty simple: it just prevents duplicate messages from being saved to Django's internal message store. This should solve the problem universally. Waiting on a review:

https://github.com/mattbasta/zamboni/commit/1979378f22d240d22fa63cc9007906903de84e5c

Comment 4

[Matt Basta [:basta]]

Merged

https://github.com/mozilla/zamboni/commit/f50407a995250709ad6a51bc2a218f8f93f17b1c

Comment 5

[Victor Carciu]

Now, the message is not displayed twice, but I observed another issue. 
The "Profile updated" message is displayed only for a second after saving the updates and then it disappear . 
From what I know, these types of messages should remain displayed until the user change the page .

Please let me know if something changed and if this is not a bug feel free to close it again.

Comment 6

[Matt Basta [:basta]]

That's a separate issue with the code that bug 795185 deals with. That code should land today.

Comment 7

[Matt Basta [:basta]]

Scratch that, Potch merged the code earlier today. You will notice that the Profile Updated message goes away rather quickly, but I'm inclined to WONTFIX that issue. It happens because we need to reload the page to get a new header, footer, and language file. There's not a lot we can do on that front, unfortunately, and that's outside the scope of this big anyway.

You will notice, however, that the corresponding issue with reviews is fixed this morning.

Comment 8

[Victor Carciu]

Thank you Matt. I will mark it as verified then .