bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Drop the plugins_report table out of Socorro

VERIFIED FIXED

Status

Socorro
Database
VERIFIED FIXED
6 years ago
10 months ago

People

(Reporter: selenamarie, Assigned: peterbe)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [deprecate])

We do not currently use this table for any reports. Confirm this is true and then remove it.
Assignee: nobody → sdeckelmann
Whiteboard: [deprecate]
Hey Kairo,

Do you know of any use of the plugins_report table? I don't see anything in the webapp. 

-selena
Flags: needinfo?(kairo)
Current list of files containing a reference to plugins_report: 

(socorro-virtualenv)selena@taiping:~/repos/socorro$ grep -l -r plugins_report *   | grep -v pyc | grep -v virtualenv | grep -v build | grep -v alembic
docs/development/breakpad-schema.pdf
docs/development/databasetablesbysource.rst
docs/development/databasetabledesc.rst
docs/development/breakpad-schema.graphml
docs/development/databaseschema.rst
socorro/external/postgresql/crashstorage.py
socorro/external/postgresql/search.py
socorro/external/postgresql/staticdata.py
socorro/external/postgresql/base.py
socorro/external/postgresql/report.py
socorro/external/postgresql/models.py
socorro/database/schema.py
socorro/database/migrations/migrateProcessType.py
socorro/unittest/external/postgresql/test_base.py
socorro/unittest/external/postgresql/test_search.py
socorro/unittest/external/postgresql/test_crashstorage.py
socorro/unittest/external/postgresql/test_report.py
socorro/unittest/external/postgresql/test_crash_data.py
plugins_reports appears in a JOIN for external/postgresql/search.py and is returned as pluginVersion

Comment 4

4 years ago
(In reply to Selena Deckelmann :selenamarie :selena from comment #1)
> Do you know of any use of the plugins_report table? I don't see anything in
> the webapp. 

My reports are not using it. What does it do?
Flags: needinfo?(kairo)
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #4)
> (In reply to Selena Deckelmann :selenamarie :selena from comment #1)
> > Do you know of any use of the plugins_report table? I don't see anything in
> > the webapp. 
> 
> My reports are not using it. What does it do?

It's a table containing the versions of plugins, but I think the info is duplicated elsewhere.

Comment 6

4 years ago
Hmm, that sounds useful in principle, but if it's really duplicated, it might not be needed.
Assignee: sdeckelmann → nobody

Updated

11 months ago
Blocks: 1361394

Updated

11 months ago
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → WONTFIX
(Assignee)

Comment 7

11 months ago
3 years ago Selena concluded that we don't use or need the plugins_reports table. Then we should delete it.
Assignee: nobody → peterbe
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
(Assignee)

Comment 8

11 months ago
https://bugzilla.mozilla.org/show_bug.cgi?id=1319956 has a PR with an alembic migration in the works. Once that's landed let's make a new alembic migration about this one.
Depends on: 1319956
(Assignee)

Updated

11 months ago
Depends on: 764673
(Assignee)

Comment 9

11 months ago
https://bugzilla.mozilla.org/show_bug.cgi?id=1394909 has an alembic migration in a PR so going to block on that getting squared away first.
Depends on: 1394909
(Assignee)

Comment 10

10 months ago
For the record, this is what we stand to drop:


breakpad=> select table_name, total, pg_size_pretty(total)
breakpad-> from (
breakpad(>  select trim(trailing '_0123456789' from table_name) as table_name, sum(pg_relation_size(table_name)) as total
breakpad(>  from information_schema.tables
breakpad(>  where table_schema = 'public' and table_name like 'plugins_reports%'
breakpad(>  group by 1
breakpad(>  ) as agg
breakpad-> order by 2 desc limit 30;
   table_name    |   total   | pg_size_pretty
-----------------+-----------+----------------
 plugins_reports | 629465088 | 600 MB
(1 row)
(Assignee)

Updated

10 months ago
Depends on: 1398195

Comment 11

10 months ago
Commit pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/68f5dcb6e07306efd363a5f635fab5e7c6191d7f
fixes bug 794524 - drop plugins_report table (#3969)

* fixes bug 794524 - drop plugins_report table

* drop sqlalchemy table too

Updated

10 months ago
Status: REOPENED → RESOLVED
Last Resolved: 11 months ago10 months ago
Resolution: --- → FIXED
(Assignee)

Comment 12

10 months ago
The only way I know to look up a bunch of plugins and versions is to use the Signature Report. And that works. As expected, since it uses SuperSearch and this not PG table.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.