Send Unsent Messages - Dialog Box is modal, unnecessarily

NEW
Unassigned

Status

--
minor
6 years ago
4 months ago

People

(Reporter: educmale, Unassigned)

Tracking

15 Branch

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20100101 Firefox/15.0.1
Build ID: 20120905151427

Steps to reproduce:

Started up TBird and there were some unsent messages....and TBird notified me of that state, requesting direction on whether to send unsent messages.

The modal status of the dialog box prevented me from going to TBird and looking to see what messages were there, before I assented to the send.





Expected results:

The Dialog box should have been non-modal.

There is no error or other condition which obligates the user to exercise  the decision [to send or not send] at a later time.   With that absence, a modal dialog box is probably not necessary.

A likely simple fix....

Comment 1

6 years ago
Can you attach a screenshot of the dialog so we are sure which one you mean?
(Reporter)

Comment 2

6 years ago
will do when i get to the laptop with TBird on it.

it pops up immediately after startup with that inquiry
(Reporter)

Comment 3

6 years ago
Created attachment 665386 [details]
png of dlg box

Comment 4

6 years ago
OK, thanks.

May not be as simple as it look like. Fortunately the existing code already shows the dialog in parallel (async) to the main app so that it does not wait for the answer. Only when the dialog is answered it just runs SendUnsentMessages(). That is very good (if it would be sync, it would be hard to change). So it seems like the only thing to do is to switch the dialog from modal to non-modal. It uses Services.prompt.confirmEx() which seems to force modal.

Bwinton, mconley, is there any good function to use that is not modal (I would not want to rewrite this into a .xul dialog:)).
Component: General → Mail Window Front End
(Reporter)

Comment 6

6 years ago
how about whatever method that is this dlg:

title: "Send Message Error"
Text:  
"Sending of message failed.
"Please verify that your Mail & Newsgroups account settings are correct and try again"
Buttons:  Ok only
(Reporter)

Comment 7

6 years ago
This is an interesting comment at/about this line...

http://mxr.mozilla.org/comm-central/source/mail/test/mozmill/shared-modules/test-window-helpers.js#343

the dlg box for this bug is presumably not the first window?
(Reporter)

Comment 8

6 years ago
aceman:  when i confronted this bug/issue, i had merely saved a message for "send later" status, and closed the program -online-; and restarted it into an online status.  

is there another place that runs a unsent msg check routine?   the one you pointed to seems to be connected with offline/online status changes

i'm reading this:
http://mxr.mozilla.org/comm-central/source/mail/base/content/msgMail3PaneWindow.js#842
(In reply to :aceman from comment #4)
> Bwinton, mconley, is there any good function to use that is not modal (I
> would not want to rewrite this into a .xul dialog:)).

What comes to mind is the XUL notification box at the bottom of the 3pane that's used for the "Know Your Rights" notification.

See: http://mxr.mozilla.org/comm-central/source/mail/base/content/specialTabs.js#829

Comment 10

6 years ago
Thanks!
bwinton, would you accept such UI?
That bar is not used much so far.
(Reporter)

Comment 11

6 years ago
aceman, does mike's suggestion allow for both non-modal and a choice to accept or decline the offer to send unsent ?
(In reply to john ruskin from comment #11)
> aceman, does mike's suggestion allow for both non-modal and a choice to
> accept or decline the offer to send unsent ?

The notification bar is definitely non-modal, and does allow you to have buttons to perform actions.

You can see the notification bar in action if you open up Thunderbird's compose window, and type one of the attachment keywords. Try "attach", and wait a second. A notification bar will appear.

(That is, of course, unless you're using Daily - in which case, this feature has regressed - the patch to fix it landed today).

(Also, the attachment keywords might be different in your locale - see the list in Preferences > Composition > General > "Keywords")
(Reporter)

Comment 13

6 years ago
Mike:

Ah.   That notification bar might be, then, an unexpected choice, since the pop up that started all this exists off the main TBird window, not a mail compose window.   Or can that thing operate in both places ?   But . . .

I like, and still suggest, the idea of a stand-alone popup since it appears [in windows, at least] in the Win bottom bar, and is useful for those [of us] that have busy screens....

The notification you suggest seems to have utility when the window actually has the user's focus.   The startup situation is one where the user hasn't placed his user-focus into the TBird window.

I'm smiling: A new thought, for me at least -- "UserFocus", as opposed to "focus" for the software windows...
(In reply to :aceman from comment #10)
> Thanks!
> bwinton, would you accept such UI?
> That bar is not used much so far.
Flags: needinfo?(bwinton)
For the record, Mike is also qualified to give ui-r+es, so you don't really need to ask me…  But yeah, I would certainly accept that.  ;)  My only concern would be having too many of them pop up at startup.

Thanks,
Blake.
Flags: needinfo?(bwinton)

Updated

6 years ago
Duplicate of this bug: 255233

Updated

6 years ago
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86_64 → All

Comment 17

a year ago
In

Bug 1425439 - Send selected unsent mails from Outbox

I described the problem of having many mails in Unsent folder
while the smtp-server refuses to accept more mails.

To set the error-box to be non-modal would not really help.
But it would help to have at least an additional command button in the dialog-box for "Cancel sending" or "Stop trying to send".

Updated

4 months ago
See Also: → bug 1484926
You need to log in before you can comment on or make changes to this bug.