Check Now button to make Thunderbird the default mail/news/rss application does nothing

RESOLVED FIXED in Thunderbird 19.0

Status

Thunderbird
Preferences
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

({polish})

Trunk
Thunderbird 19.0
x86
Linux
polish

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.42 KB, patch
mconley
: review+
andreasn
: ui-review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
+++ This bug was initially created as a clone of Bug #262362 comment 8+++

For me on Linux and KDE3 the "Check now" button in preferences->Advanced->General is shown but does nothing. No message in the Rrror console. From looking at the code the button is wrapped inside #ifdef HAVE_SHELL_SERVICE but that seems to be set for linux-gtk2 globally. I have it set but getting the shell-service throws and exception. The code hides the exception and exits cleanly. I have gconf installed but maybe it does not work.

I think the buttons should not be exposed if we can know if it will work, via checking the shell-service.
(Assignee)

Comment 1

5 years ago
Created attachment 665259 [details] [diff] [review]
patch

This patch hides the button and the checkbox, because also the "search intergration" checkbox in the same groupbox is hidden on unsupported systems. Or is it better to just disable it?
Attachment #665259 - Flags: ui-review?(bwinton)

Comment 2

5 years ago
My take would be it's better to disable. Otherwise someone knowing where it is would be looking all over the place in vain. Also, because it should be possible to make it work by installing whatever packages are needed.
(Assignee)

Comment 3

5 years ago
That does make sense. Bwinton?
(In reply to :aceman from comment #3)
> That does make sense. Bwinton?

Yep.
(Assignee)

Comment 5

5 years ago
Created attachment 665549 [details] [diff] [review]
patch v2
Attachment #665259 - Attachment is obsolete: true
Attachment #665259 - Flags: ui-review?(bwinton)
(Assignee)

Updated

5 years ago
Attachment #665549 - Flags: ui-review?(bwinton)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Comment on attachment 665549 [details] [diff] [review]
patch v2

Yoink!
Attachment #665549 - Flags: ui-review?(bwinton) → ui-review?(mconley)
(Assignee)

Comment 7

5 years ago
mconley, stolen review but no r+ ? :)
(Assignee)

Updated

5 years ago
Attachment #665549 - Flags: ui-review?(mconley)
Attachment #665549 - Flags: ui-review?(bwinton)
Attachment #665549 - Flags: review?(mconley)
Comment on attachment 665549 [details] [diff] [review]
patch v2

(Redirecting to Andreas, since he's got a Linux build, and I would have to update mine, which would take about half a day.  ;)
Attachment #665549 - Flags: ui-review?(bwinton) → ui-review?(bugs)
Comment on attachment 665549 [details] [diff] [review]
patch v2

Looks good in the disabled state.
Attachment #665549 - Flags: ui-review?(bugs) → ui-review+
Comment on attachment 665549 [details] [diff] [review]
patch v2

Review of attachment 665549 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Attachment #665549 - Flags: review?(mconley) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/75c34c5a6caa
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in before you can comment on or make changes to this bug.