Last Comment Bug 794739 - Check Now button to make Thunderbird the default mail/news/rss application does nothing
: Check Now button to make Thunderbird the default mail/news/rss application do...
Status: RESOLVED FIXED
: polish
Product: Thunderbird
Classification: Client Software
Component: Preferences (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: Thunderbird 19.0
Assigned To: :aceman
:
:
Mentors:
Depends on: 262362
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-26 22:54 PDT by :aceman
Modified: 2012-11-08 10:51 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (1.45 KB, patch)
2012-09-26 22:58 PDT, :aceman
no flags Details | Diff | Splinter Review
patch v2 (1.42 KB, patch)
2012-09-27 11:12 PDT, :aceman
mconley: review+
bugs: ui‑review+
Details | Diff | Splinter Review

Description :aceman 2012-09-26 22:54:46 PDT
+++ This bug was initially created as a clone of Bug #262362 comment 8+++

For me on Linux and KDE3 the "Check now" button in preferences->Advanced->General is shown but does nothing. No message in the Rrror console. From looking at the code the button is wrapped inside #ifdef HAVE_SHELL_SERVICE but that seems to be set for linux-gtk2 globally. I have it set but getting the shell-service throws and exception. The code hides the exception and exits cleanly. I have gconf installed but maybe it does not work.

I think the buttons should not be exposed if we can know if it will work, via checking the shell-service.
Comment 1 :aceman 2012-09-26 22:58:36 PDT
Created attachment 665259 [details] [diff] [review]
patch

This patch hides the button and the checkbox, because also the "search intergration" checkbox in the same groupbox is hidden on unsupported systems. Or is it better to just disable it?
Comment 2 Magnus Melin 2012-09-26 23:01:29 PDT
My take would be it's better to disable. Otherwise someone knowing where it is would be looking all over the place in vain. Also, because it should be possible to make it work by installing whatever packages are needed.
Comment 3 :aceman 2012-09-27 01:05:40 PDT
That does make sense. Bwinton?
Comment 4 Blake Winton (:bwinton) (:☕️) 2012-09-27 08:12:53 PDT
(In reply to :aceman from comment #3)
> That does make sense. Bwinton?

Yep.
Comment 5 :aceman 2012-09-27 11:12:56 PDT
Created attachment 665549 [details] [diff] [review]
patch v2
Comment 6 Mike Conley (:mconley) 2012-10-10 23:01:43 PDT
Comment on attachment 665549 [details] [diff] [review]
patch v2

Yoink!
Comment 7 :aceman 2012-10-21 08:34:48 PDT
mconley, stolen review but no r+ ? :)
Comment 8 Blake Winton (:bwinton) (:☕️) 2012-10-29 09:41:52 PDT
Comment on attachment 665549 [details] [diff] [review]
patch v2

(Redirecting to Andreas, since he's got a Linux build, and I would have to update mine, which would take about half a day.  ;)
Comment 9 Andreas Nilsson (:andreasn) 2012-11-03 12:07:25 PDT
Comment on attachment 665549 [details] [diff] [review]
patch v2

Looks good in the disabled state.
Comment 10 Mike Conley (:mconley) 2012-11-07 17:58:31 PST
Comment on attachment 665549 [details] [diff] [review]
patch v2

Review of attachment 665549 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Comment 11 Ryan VanderMeulen [:RyanVM] 2012-11-08 10:51:02 PST
https://hg.mozilla.org/comm-central/rev/75c34c5a6caa

Note You need to log in before you can comment on or make changes to this bug.