794881 - Phone state to dialing or connected will clear ForceForUse to None

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Marco Chen [:mchen]]

On the test of BT SCO feature, the voice will be came from handset not BT_SCO.

Re-produce Steps:
  1. parring the BT handset with phone on SCO profile.
  2. Make a MO call.

Expected Result:
  Remote voice is came from BT handset.

Failed Result:
  Remote voice is came from handset.

Comment 1

[Marco Chen [:mchen]]

Attachment: WIPv1

During phone state of dialing or connected and speakerEnabled not set, the AudioManager.ForceForUse(NONE) can't be called or will overwrite existing value Ex: BT_SCO during communication mode.

Comment 2

[Philipp von Weitershausen [:philikon]]

Comment on attachment 665352 [details] [diff] [review]
WIPv1

Review of attachment 665352 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +836,5 @@
>        case nsIRadioInterfaceLayer.CALL_STATE_CONNECTED:
>          gAudioManager.phoneState = nsIAudioManager.PHONE_STATE_IN_CALL;
> +        if( this.speakerEnabled )
> +          gAudioManager.setForceForUse(nsIAudioManager.USE_COMMUNICATION,
> +                                       nsIAudioManager.FORCE_SPEAKER);

Style nits:

  if (this.speakerEnabled) {
    gAudioManager.setForceForUse(nsIAudioManager.USE_COMMUNICATION,
                                 nsIAudioManager.FORCE_SPEAKER);
  }

Basically:

* Correct use of whitespace for `if`
* Always need braces for blocks

Tip: pay attention to surrounding style when modifying files. 

r=me with that.

Comment 3

[Marco Chen [:mchen]]

Attachment: Reviewed_Patch

Follow Philikon's comment and thanks for advice.

Comment 4

[(PTO May 7-12) Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ce8440e0e2f

Should this have a test?

Comment 5

[(PTO May 7-12) Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6ce8440e0e2f